The docstring of twisted.python.components.Componentized.addComponent is not consistent with its code

[Yaroslav Fedevych]

This docstring contains the following:

  @return: the list of appropriate interfaces

While the code itself does not have any return statement at all.

The only instance of code invoking addComponent, at twisted.application.service.Application, does not expect any return value.

Either docstring should be fixed to not mention return values, or the code should actually return it.

[Ken]

This doc issue annoyed me. I took a peek and there has never been, in the past decade, a point at which addComponent returned something... so it seems simpler to just remove the trick documentation instead of fixing the code.

[Stephen Thorne]

Please also document the parameters, component and ignoreClass. They're documented in prose but need @param annotations.

[Stephen Thorne]

Please also document the parameters, component and ignoreClass. They're documented in prose but need @param annotations.

[Ken]

v2 patch, fixed a few more things.

[Jonathan Jacobs]

(In [37892]) Branching to 'python-components-docs-5174'

[Jonathan Jacobs]

(In [37896]) Fix some minor grammatical errors, refs #5174.

[Jonathan Jacobs]

Thank you for improving the documentation in Twisted, in particular removing the use of a first-person narrative!

Some issues I noticed with your patch:

1. Some docstrings contain annotations like #param ..., I've looked through the epytext syntax specification and I can't find what this means, I suspect it may just be a typo of @param ....

2. When your epytext field (such as @param) is wrapped over multiple lines, the wrapped lines (that is, from the second line onwards) need to be indented. See the docstring for proxyForInterface for an example.

3. Some field annotations do not begin with a capital letter and/or end with a period.

4. The text *Twisted* will appear literally as-is, if you are trying to italicize text you need to use I{Twisted} or B{Twisted} for bold.

5. Some @param fields have been adapted from more general text but still refer to themselves in the third person, addAdapter's ignoreClass parameter is one such example.

6. There are a few ​Twisted coding standard violations that were either introduced or were already present:

1. Docstring opening and closing triple quotes should appear on lines by themselves.

2. There should be 3 new lines between class definitions and 2 new lines between method definitions.

7. The ​Twisted checker buildbot happens to contain a list of ​newly introduced twisted checker warnings, please fix these. Although there are some existing checker issues that should be fixed too:

1. Methods should document their return value with @return.

I also took the liberty of creating a branch and applying your patch, as well as fixing some minor grammatical errors, please base future diffs on this branch.