Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#5127 task closed fixed (fixed)

Remove deprecated functions in `lore/tree.py`

Reported by: Facundo Batista Owned by:
Priority: normal Milestone:
Component: lore Keywords:
Cc: Thijs Triemstra Branch: branches/lore-tree-compare-5127
branch-diff, diff-cov, branch-cov, buildbot
Author: facundobatista

Description

This patch remove compareMarkPos and comparePosition from lore/tree.py, as they were deprecated for v9.

Attachments (1)

remove-lore-tree-deprecated-a.patch (2.5 KB) - added by Facundo Batista 6 years ago.

Download all attachments as: .zip

Change History (9)

Changed 6 years ago by Facundo Batista

comment:1 Changed 6 years ago by Thijs Triemstra

Cc: Thijs Triemstra added
Component: corelore
Keywords: py3k removed
Type: enhancementtask

comment:2 Changed 6 years ago by Thijs Triemstra

Author: thijs
Branch: branches/lore-tree-compare-5127

(In [32110]) Branching to 'lore-tree-compare-5127'

comment:3 Changed 6 years ago by Thijs Triemstra

(In [32111]) Apply remove-lore-tree-deprecated-a.patch, add news file. refs #5127

comment:4 Changed 6 years ago by Thijs Triemstra

Author: thijsfacundobatista

The doc build succeeded after this change (isnt that all that matters ;). Branch up for review.

comment:5 Changed 6 years ago by Ying Li

(In [32125]) Removed the unused twisted versions import as well

refs #5127

comment:6 Changed 6 years ago by Ying Li

build results look good. Merging. Thanks for applying the patch thijs!

comment:7 Changed 6 years ago by Ying Li

Resolution: fixed
Status: newclosed

(In [32126]) Merge lore-tree-compare-5127: Remove deprecated compare methods in lore

Author: facundobatista Reviewer: cyli Fixes: #5127

Removes twisted.lore.tree.compareMarkPos and twisted.lore.tree.comparePosition, both of which were deprecated in v9.0.

comment:8 Changed 6 years ago by Ying Li

Keywords: review removed
Note: See TracTickets for help on using tickets.