Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#5127 task closed fixed (fixed)

Remove deprecated functions in `lore/tree.py`

Reported by: facundobatista Owned by:
Priority: normal Milestone:
Component: lore Keywords:
Cc: thijs Branch: branches/lore-tree-compare-5127
branch-diff, diff-cov, branch-cov, buildbot
Author: facundobatista

Description

This patch remove compareMarkPos and comparePosition from lore/tree.py, as they were deprecated for v9.

Attachments (1)

remove-lore-tree-deprecated-a.patch​ (2.5 KB) - added by facundobatista 5 years ago.

Download all attachments as: .zip

Change History (9)

Changed 5 years ago by facundobatista

comment:1 Changed 5 years ago by thijs

  • Cc thijs added
  • Component changed from core to lore
  • Keywords py3k removed
  • Type changed from enhancement to task

comment:2 Changed 5 years ago by thijs

  • Author set to thijs
  • Branch set to branches/lore-tree-compare-5127

(In [32110]) Branching to 'lore-tree-compare-5127'

comment:3 Changed 5 years ago by thijs

(In [32111]) Apply remove-lore-tree-deprecated-a.patch, add news file. refs #5127

comment:4 Changed 5 years ago by thijs

  • Author changed from thijs to facundobatista

The ​doc build succeeded after this change (isnt that all that matters ;). Branch up for review.

comment:5 Changed 5 years ago by cyli

(In [32125]) Removed the unused twisted versions import as well

refs #5127

comment:6 Changed 5 years ago by cyli

​build results look good. Merging. Thanks for applying the patch thijs!

comment:7 Changed 5 years ago by cyli

  • Resolution set to fixed
  • Status changed from new to closed

(In [32126]) Merge lore-tree-compare-5127: Remove deprecated compare methods in lore

Author: facundobatista Reviewer: cyli Fixes: #5127

Removes twisted.lore.tree.compareMarkPos and twisted.lore.tree.comparePosition, both of which were deprecated in v9.0.

comment:8 Changed 5 years ago by cyli

  • Keywords review removed
Note: See TracTickets for help on using tickets.