Opened 8 years ago
Closed 8 years ago
#5088 release blocker: regression closed fixed (fixed)
cfreactor cannot be imported
Reported by: | Jean-Paul Calderone | Owned by: | Jean-Paul Calderone |
---|---|---|---|
Priority: | highest | Milestone: | Twisted-11.1 |
Component: | core | Keywords: | |
Cc: | Branch: |
branches/cfreactor-import-5088
branch-diff, diff-cov, branch-cov, buildbot |
|
Author: | exarkun |
Description
>>> from twisted.internet import cfreactor /System/Library/Frameworks/Python.framework/Versions/2.6/Extras/lib/python/zope/__init__.py:1: UserWarning: Module twisted was already imported from twisted/__init__.pyc, but /System/Library/Frameworks/Python.framework/Versions/2.6/Extras/lib/python is being added to sys.path __import__('pkg_resources').declare_namespace(__name__) Traceback (most recent call last): File "<stdin>", line 1, in <module> File "/Users/exarkun/Projects/Twisted/trunk/twisted/internet/cfreactor.py", line 24, in <module> from twisted.internet.selectreactor import _NO_FILENO, _NO_FILEDESC ImportError: cannot import name _NO_FILENO
Change History (12)
comment:1 Changed 8 years ago by
comment:2 follow-up: 3 Changed 8 years ago by
Because ImportError
gets turned into a skip automatically for the reactor builder tests.
comment:3 Changed 8 years ago by
I guess I meant it as a rhetorical question.
Put more directly: one aspect of this fix should be a platform-specific "this should always run" thing which tells the OS X slaves to puke if they can't import this reactor for any reason.
comment:4 Changed 8 years ago by
Priority: | normal → highest |
---|
Regression, so: highest priority. I would just revert the other change but it looks like an important bugfix for its own right.
comment:5 Changed 8 years ago by
Milestone: | → Twisted-11.1 |
---|
And it needs to be completed before 11.1.
comment:6 Changed 8 years ago by
Owner: | set to Glyph |
---|---|
Status: | new → assigned |
I guess I'll take it over.
comment:7 Changed 8 years ago by
Author: | → exarkun |
---|---|
Branch: | → branches/cfreactor-import-5088 |
(In [31936]) Branching to 'cfreactor-import-5088'
comment:8 Changed 8 years ago by
Anything else that needs to be done before this can go into review, other than adding a newsfile? This is only remaining blocker for 11.1.
comment:9 Changed 8 years ago by
Keywords: | review added |
---|---|
Owner: | Glyph deleted |
Status: | assigned → new |
comment:10 Changed 8 years ago by
Keywords: | review removed |
---|---|
Owner: | set to Jean-Paul Calderone |
Thanks for turning the crank. Land it.
comment:11 Changed 8 years ago by
I filed #5216 to try to improve the reactor builder tests so we won't see something like this again.
comment:12 Changed 8 years ago by
Resolution: | → fixed |
---|---|
Status: | new → closed |
Looks like #4539 is the culprit. Why don't we have a failing buildbot?