Opened 5 years ago

Closed 5 years ago

#5057 enhancement closed fixed (fixed)

We need an IResponse interface

Reported by: therve Owned by: therve
Priority: normal Milestone:
Component: web Keywords: easy
Cc: jknight Branch: branches/iresponse-5057
(github, coverage, patch, buildbot, log)
Author: therve

Description

To be able to wrap web client Response class properly, an interface would help. It would also have some documentation benefits.

Change History (5)

comment:1 Changed 5 years ago by DefaultCC Plugin

  • Cc jknight added

comment:2 Changed 5 years ago by therve

  • Author set to therve
  • Branch set to branches/iresponse-5057

(In [31702]) Branching to 'iresponse-5057'

comment:3 Changed 5 years ago by therve

  • Keywords review easy added
  • Owner therve deleted

Please review.

comment:4 Changed 5 years ago by exarkun

  • Keywords review removed
  • Owner set to therve
  1. IResponse should be added to twisted.web.iweb.__all__.
  2. If we want IResponse to be the main thing people look at (instead of Response), maybe all of the docs on Response should be on IResponse (eg, the rest of the deliverBody docstring and the type information for the attributes) and the Response docstrings can focus on just the particulars of its implementation?
  3. IResponse should have @since I guess (we should automate that though)

Otherwise looks good (build results, too), merge when those are fixed. Thanks!

comment:5 Changed 5 years ago by therve

  • Resolution set to fixed
  • Status changed from new to closed

(In [31820]) Merge iresponse-5057

Author: therve Reviewier: exarkun Fixes: #5057

Create a IResponse interface to represent the Response returned by twisted.web.client.Agent.deliverBody.

Note: See TracTickets for help on using tickets.