Opened 8 years ago

Closed 8 years ago

#5003 enhancement closed fixed (fixed)

replace call to functions from the string module in test

Reported by: Juan A. Diaz Owned by: lvh
Priority: normal Milestone:
Component: core Keywords: py3k
Cc: Branch: branches/str-methods-test-5003
branch-diff, diff-cov, branch-cov, buildbot
Author: lvh

Description

To make the port to python 3k more easy, I'm replacing all the calls to functions from the string module, for their equivalent from the str type object or calling directly to the built-in method of the string variable.

Attachments (1)

test.patch (2.3 KB) - added by Juan A. Diaz 8 years ago.
patch

Download all attachments as: .zip

Change History (6)

Changed 8 years ago by Juan A. Diaz

Attachment: test.patch added

patch

comment:1 Changed 8 years ago by lvh

Author: lvh
Branch: branches/str-methods-test-5003

(In [31472]) Branching to 'str-methods-test-5003'

comment:2 Changed 8 years ago by lvh

Owner: set to lvh
Status: newassigned

comment:4 Changed 8 years ago by lvh

Keywords: review removed

Looks good! Thanks for your patch, added to my patch queue for tomorrow.

comment:5 Changed 8 years ago by lvh

Resolution: fixed
Status: assignedclosed

(In [31554]) Replaced calls to functions from the string module in twisted.test.

Author: nueces Reviewers: lvh Fixes: #5003

twisted.test was previously using deprecated calls to functions in the string module, which are deprecated in favor of str methods.

Note: See TracTickets for help on using tickets.