Opened 8 years ago

Closed 2 years ago

#5002 enhancement closed fixed (fixed)

replace call to functions from the string module in spread

Reported by: Juan A. Diaz Owned by:
Priority: normal Milestone: Python-3.x
Component: core Keywords: py3k
Cc: Branch: branches/str-methods-spread-5002
branch-diff, diff-cov, branch-cov, buildbot
Author: lvh

Description

To make the port to python 3k more easy, I'm replacing all the calls to functions from the string module, for their equivalent from the str type object or calling directly to the built-in method of the string variable.

Attachments (1)

spread.patch (841 bytes) - added by Juan A. Diaz 8 years ago.
patch

Download all attachments as: .zip

Change History (9)

Changed 8 years ago by Juan A. Diaz

Attachment: spread.patch added

patch

comment:1 Changed 8 years ago by lvh

Owner: set to lvh
Status: newassigned

comment:2 Changed 8 years ago by lvh

Keywords: review removed

Like the last one, this is just too trivial to warrant a buildbot build.

Thanks for your patch! Added to my commit queue.

comment:3 Changed 8 years ago by lvh

Author: lvh
Branch: branches/str-methods-spread-5002

(In [31469]) Branching to 'str-methods-spread-5002'

comment:4 Changed 8 years ago by Jean-Paul Calderone

Um. Unit tests?

comment:5 Changed 8 years ago by lvh

Owner: changed from lvh to Juan A. Diaz
Status: assignednew

What JP said -- this patch modifies untested code, so it should be tested first, either in this patch or in a separate ticket. Reassigning to nueces -- if you'd rather not write the relevant tests, please unassign yourself.

comment:6 Changed 8 years ago by Thijs Triemstra

Milestone: Python-3.x

comment:7 Changed 7 years ago by Thijs Triemstra

Owner: Juan A. Diaz deleted

comment:8 Changed 2 years ago by Craig Rodrigues

Resolution: fixed
Status: newclosed

Fixed via other commits.

Note: See TracTickets for help on using tickets.