Opened 11 years ago

Closed 11 years ago

#4855 defect closed fixed (fixed)

twisted.web.xmlrpc.withRequest takes extra arguments and has no @since tag

Reported by: Jean-Paul Calderone Owned by: Jean-Paul Calderone
Priority: normal Milestone:
Component: web Keywords: easy
Cc: jknight Branch:
Author:

Description

withRequest is a decorator, but it takes *args, **kwargs for some reason. The docstring also doesn't note that it was added in 10.2.

Attachments (1)

withrequest-since.patch (723 bytes) - added by Jean-Paul Calderone 11 years ago.

Download all attachments as: .zip

Change History (8)

comment:1 Changed 11 years ago by DefaultCC Plugin

Cc: jknight added

comment:2 Changed 11 years ago by Jean-Paul Calderone

Keywords: easy added

comment:3 Changed 11 years ago by <automation>

Changed 11 years ago by Jean-Paul Calderone

Attachment: withrequest-since.patch added

comment:4 Changed 11 years ago by Jean-Paul Calderone

Keywords: review added

comment:5 Changed 11 years ago by Moshe Zadka

Keywords: review removed
Owner: set to Moshe Zadka
Status: newassigned

comment:6 Changed 11 years ago by Moshe Zadka

Owner: changed from Moshe Zadka to Jean-Paul Calderone
Status: assignednew

Looks good.

comment:7 Changed 11 years ago by Jean-Paul Calderone

Resolution: fixed
Status: newclosed

(In [30971]) Remove extraneous arguments from withRequest signature and mark the version in which it was introduced.

Author: exarkun Reviewer: moshez Fixes: #4855

Note: See TracTickets for help on using tickets.