Opened 10 years ago
Closed 10 years ago
#4695 enhancement closed fixed (fixed)
plugin registration for extensions to endpoints.serverFromString and endpoints.clientFromString
Reported by: | Glyph | Owned by: | |
---|---|---|---|
Priority: | normal | Milestone: | |
Component: | core | Keywords: | |
Cc: | Branch: |
branches/endpoints-plugins-4695
branch-diff, diff-cov, branch-cov, buildbot |
|
Author: | glyph |
Description (last modified by )
Originally #4473 specified a plugin API, but that was biting off more than a single ticket could chew by a wide margin. This ticket is to complete that work.
As originally specified:
(
serverFromString
andclientFromString
) should be implemented in terms of a pluggable API, like the one intwisted.cred.strcred
, so that third parties can supply their own Twisted transports and built-in protocols can be invoked using them.
Change History (13)
comment:1 Changed 10 years ago by
Description: | modified (diff) |
---|
comment:2 Changed 10 years ago by
Author: | → glyph |
---|---|
Branch: | → branches/endpoints-plugins-4695 |
comment:4 Changed 10 years ago by
Keywords: | review removed |
---|---|
Owner: | set to Glyph |
- The class docstring for
IStreamClientEndpointStringParser
ends with "plugin method" but probably means "prefix method" - Why is prefix a method and not just an attribute?
- The unrecognized prefix case of
clientFromString
is untested and probably should more closely resemble the behavior ofserverFromString
in that case - currently the caller will get TypeError: 'NoneType' object is not callable. - Needs a news fragment
comment:7 Changed 10 years ago by
comment:8 Changed 10 years ago by
comment:9 Changed 10 years ago by
comment:10 Changed 10 years ago by
Keywords: | review added |
---|---|
Owner: | Glyph deleted |
Build results (see link above) ready with the usual potpourri of Windows failures; I think that addresses all the points of feedback.
comment:11 Changed 10 years ago by
Keywords: | review removed |
---|---|
Owner: | set to Glyph |
- The first line of endpoints.py belongs somewhere else
Otherwise, great, please merge!
comment:12 Changed 10 years ago by
Resolution: | → fixed |
---|---|
Status: | new → closed |
comment:13 Changed 10 years ago by
Owner: | Glyph deleted |
---|
Note: See
TracTickets for help on using
tickets.
(In [30304]) Branching to 'endpoints-plugins-4695'