Opened 11 years ago

Closed 10 years ago

#4683 task closed fixed (fixed)

twisted.web.sux probably shouldn't be runnable

Reported by: lvh Owned by: Thijs Triemstra
Priority: low Milestone:
Component: web Keywords:
Cc: Thijs Triemstra, ivank Branch:
Author:

Description

When cleaning up the source tree for stuff that still referenced doc/howto instead of doc/core/howto, I stumbled across t.w.sux.

http://twistedmatrix.com/trac/browser/tags/releases/twisted-8.1.0/twisted/web/sux.py#L639

I think that should be cleaned out. In fact I'm not sure why it's runnable at all. Can't we just remove the entire if __name__ == '__main__': block?

Attachments (1)

sux-main-4683.patch (819 bytes) - added by Thijs Triemstra 10 years ago.

Download all attachments as: .zip

Change History (5)

comment:1 Changed 11 years ago by <automation>

Owner: jknight deleted

Changed 10 years ago by Thijs Triemstra

Attachment: sux-main-4683.patch added

comment:2 Changed 10 years ago by Thijs Triemstra

Cc: Thijs Triemstra added
Keywords: review added
Priority: normallow

comment:3 Changed 10 years ago by ivank

Cc: ivank added
Keywords: review removed
Owner: set to Thijs Triemstra
Type: enhancementtask
  1. This needs an empty news file twisted/web/topfiles/4683.misc

Otherwise, looks good for merging.

comment:4 Changed 10 years ago by Jean-Paul Calderone

Resolution: fixed
Status: newclosed

(In [31903]) Delete twisted.web.sux script support

Author: thijs Reviewer: ivank Fixes: #4683

Remove the self-check __main__ code from twisted.web.sux. The module is tested by unit tests in twisted.test.test_xml.

Note: See TracTickets for help on using tickets.