Opened 7 years ago
Closed 7 years ago
#4562 defect closed fixed (fixed)
Cyclic dependency between twisted.test.test_failure and twisted.test.generator_failure_tests
| Reported by: | Jean-Paul Calderone | Owned by: | |
|---|---|---|---|
| Priority: | normal | Milestone: | |
| Component: | core | Keywords: | |
| Cc: | jesstess | Branch: |
branches/generator-tests-cycle-4562
branch-diff, diff-cov, branch-cov, buildbot |
| Author: | exarkun |
Description
test_failure imports generator_failure_tests. generator_failure_tests imports test_failure. This works as long as test_failure gets loaded first, but fails as soon as you try to start with generator_failure_tests (which you can observe by picking them specifically with trial: trial twisted.test.generator_failure_tests).
The dependency is really shallow though, so it should be easy to fix.
This is something that was discovered in the #1784, and the fix is pulled straight from that branch as well.
Change History (6)
comment:1 Changed 7 years ago by
| Author: | → exarkun |
|---|---|
| Branch: | → branches/generator-tests-cycle-4562 |
comment:2 Changed 7 years ago by
| Keywords: | easy review added |
|---|---|
| Owner: | Jean-Paul Calderone deleted |
comment:4 Changed 7 years ago by
| Cc: | jesstess added |
|---|---|
| Keywords: | tests easy review removed |
| Owner: | set to Jean-Paul Calderone |
Thanks for fixing this, exarkun. Looks good to merge.
comment:5 Changed 7 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
comment:6 Changed 7 years ago by
| Owner: | Jean-Paul Calderone deleted |
|---|
Note: See
TracTickets for help on using
tickets.
(In [29737]) Branching to 'generator-tests-cycle-4562'