Opened 9 years ago

Closed 3 years ago

#4426 enhancement closed wontfix (wontfix)

tap2deb should generate LSB headers for DependencyBasedBoot

Reported by: Norman Rasmussen Owned by: Norman Rasmussen
Priority: normal Milestone:
Component: core Keywords: tap2deb
Cc: Branch:
Author:

Description

ref: http://wiki.debian.org/LSBInitScripts/DependencyBasedBoot

probably need to add something like:

### BEGIN INIT INFO
# Provides:          $(deb_file)s
# Required-Start:    $remote_fs $time $network $named
# Required-Stop:     $remote_fs $time $network $named
# Default-Start:     2 3 4 5
# Default-Stop:      0 1 6
### END INIT INFO

Change History (7)

comment:1 Changed 9 years ago by Norman Rasmussen

btw, I also had to change the rules file to install to debian/$(deb_file)s/... instead of debian/tmp/...

comment:2 Changed 9 years ago by Jean-Paul Calderone

Owner: changed from Glyph to Norman Rasmussen

Thanks.

tap2deb is one of the corners of Twisted that is less likely to get much attention, unless the attention comes from you. :)

As a start, I wonder if you can provide information about which versions of Debian this works with, and present the change as a patch to tap2deb? If you can think of a way to test this change, that would also be excellent. If not, changing the way tap2deb stores this information to make unit tests a little less pressing might be good; for example, perhaps it should be stored in an external text file, not as a string inline in the Python source.

Thanks again.

comment:3 Changed 9 years ago by Norman Rasmussen

Sure I can certainly look at supplying a patch. (fyi: debian/tmp/ went out of fashion at debhelper v2 (it's now at v7))

With the deprecation of mktap, maybe I should look at putting the args into default/deb_file and making that non-world readable? (and possibly make this a new script called mktwistddeb (sp) or something like that?)

The quickest way to test is to run debuild and check that a .deb file is created. :-)

comment:4 Changed 9 years ago by Jean-Paul Calderone

The quickest way to test is to run debuild and check that a .deb file is created. :-)

Keep in mind that not everyone might know how to run debuild. Anyone who doesn't might feel somewhat disinclined to review or otherwise help out with this ticket.

(To take a random example, I don't know how to run debuild.)

comment:5 in reply to:  4 Changed 9 years ago by Norman Rasmussen

Replying to exarkun:

The quickest way to test is to run debuild and check that a .deb file is created. :-)

Keep in mind that not everyone might know how to run debuild. Anyone who doesn't might feel somewhat disinclined to review or otherwise help out with this ticket.

(To take a random example, I don't know how to run debuild.)

Sure, the only pre-requisite is that you're running on a debian/ubuntu based system with the build-essential package installed.

Debian New Maintainers' Guide - Chapter 6 - Building the package contains the gritty details, but practically you can just run 'debuild'.

If it's going to be scripted then apparently 'debuild -i -us -uc -b' is a better option (copied from the man page), as that will skip: source control files (like CVS/.svn/etc), source.deb generation (don't need to distribute it, so don't need to build it), gpg signing (don't need for testing).

comment:6 Changed 9 years ago by Jean-Paul Calderone

Taking a closer look at this now, I'm not sure what the suggestion in the description really means. I just had a look at twisted/scripts/tap2deb.py, but it's not clear to me where the additions need to be made (again, a patch would be nice :).

comment:7 Changed 3 years ago by hawkowl

Resolution: wontfix
Status: newclosed

No, it shouldn't -- tap2deb is deprecated.

Note: See TracTickets for help on using tickets.