Opened 12 years ago

Closed 12 years ago

#4409 task closed fixed (fixed)

Finish writing test_optionalAmpListOmitted

Reported by: Jean-Paul Calderone Owned by:
Priority: normal Milestone:
Component: core Keywords: amp, tests
Cc: Richard Wall Branch: branches/optional-amp-list-test-4409
branch-diff, diff-cov, branch-cov, buildbot
Author: exarkun

Description

twisted/test/test_amp.py has a test, test_optionalAmpListOmitted, with no real content.

It should be written.

Change History (6)

comment:1 Changed 12 years ago by Jean-Paul Calderone

Author: exarkun
Branch: branches/optional-amp-list-test-4409

(In [28870]) Branching to 'optional-amp-list-test-4409'

comment:2 Changed 12 years ago by Jean-Paul Calderone

(In [28871]) Test a command with an optional AmpList with no supplied value

refs #4409

comment:3 Changed 12 years ago by Jean-Paul Calderone

Keywords: review added
Owner: Glyph deleted

comment:4 Changed 12 years ago by Richard Wall

Cc: Richard Wall added
Keywords: review removed
Owner: set to Jean-Paul Calderone
  • New test function body makes sense
  • test docstring is clearer
  • All AMP tests pass

Please merge

comment:5 Changed 12 years ago by Jean-Paul Calderone

Resolution: fixed
Status: newclosed

(In [28903]) Merge optional-amp-list-test-4409

Author: exarkun Reviewer: rwall Fixes: #4409

Finish writing an AMP test for the omission of a value for an optional AmpList parameter.

comment:6 Changed 11 years ago by <automation>

Owner: Jean-Paul Calderone deleted
Note: See TracTickets for help on using tickets.