Opened 8 years ago

Closed 8 years ago

#4233 defect closed wontfix (wontfix)

typo in connectUNIXDatagram

Reported by: jesstess Owned by:
Priority: normal Milestone:
Component: core Keywords:
Cc: jesstess Branch: branches/datagram-mode-4233
branch-diff, diff-cov, branch-cov, buildbot
Author: jesstess

Description

-        mopde = self._checkMode('IReactorUNIXDatagram.connectUNIXDatagram', mode)
+        mode = self._checkMode('IReactorUNIXDatagram.connectUNIXDatagram', mode)
         p = unix.ConnectedDatagramPort(address, protocol, maxPacketSize, mode, bindAddress, self)

So the effects of _checkMode aren't propagated to ConnectedDatagramPort.

Change History (13)

comment:1 Changed 8 years ago by Jean-Paul Calderone

I guess we're going to undeprecate the mode parameter anyway... #4078

comment:2 Changed 8 years ago by jesstess

Author: jesstess
Branch: branches/datagram-mode-4233

(In [28094]) Branching to 'datagram-mode-4233'

comment:3 Changed 8 years ago by jesstess

(In [28095]) Fix mode typo in PosixReactorBase.connectUNIXDatagram and add unit tests for modes in that function.

refs #4233

comment:4 Changed 8 years ago by jesstess

Keywords: review added
Owner: jesstess deleted

comment:5 Changed 8 years ago by jesstess

Keywords: review removed
Owner: set to jesstess

comment:6 Changed 8 years ago by jesstess

(In [28096]) Restore original unix.ConnectedDatagramPort after using a dummy class for testing.

refs #4233

comment:7 Changed 8 years ago by jesstess

Keywords: review added

comment:8 Changed 8 years ago by jesstess

Owner: jesstess deleted

comment:9 Changed 8 years ago by jesstess

Keywords: review removed
Owner: set to jesstess

comment:10 Changed 8 years ago by jesstess

Resolving #4078 makes this obsolete.

comment:11 Changed 8 years ago by khorn

Should this be resolved now that #4078 has been closed?

comment:12 Changed 8 years ago by Jean-Paul Calderone

Resolution: wontfix
Status: newclosed

Yep, thanks.

comment:13 Changed 7 years ago by <automation>

Owner: jesstess deleted
Note: See TracTickets for help on using tickets.