Opened 9 years ago

Closed 3 years ago

#4230 defect closed invalid (invalid)

Correct exception text in twisted.web2.http_headers:HeaderHandler

Reported by: asvetlov Owned by: asvetlov
Priority: low Milestone:
Component: web2 Keywords:
Cc: Thijs Triemstra, khorn Branch:


Now exception message from HeaderHandler .generate/.parse refers to non-existent Headers methods .getHeaderRaw/.setHeaderRaw while real names are getRawHeaders/setRawHeaders. patch attached.

Attachments (1)

web2.patch (977 bytes) - added by asvetlov 9 years ago.

Download all attachments as: .zip

Change History (5)

Changed 9 years ago by asvetlov

Attachment: web2.patch added


comment:1 Changed 9 years ago by khorn

Grepping through the code, it looks like this is the only occurrence of "getHeaderRaw" and "setHeaderRaw", so I think this change is fine.

comment:2 Changed 9 years ago by Thijs Triemstra

Cc: Thijs Triemstra added
Keywords: review added
Owner: David Reid deleted

comment:3 Changed 9 years ago by Jean-Paul Calderone

Cc: khorn added
Keywords: review removed
Owner: set to asvetlov

There's no test coverage for either of the two modified lines.

comment:4 Changed 3 years ago by hawkowl

Resolution: invalid
Status: newclosed

Web2 does not exist anymore.

Note: See TracTickets for help on using tickets.