Opened 10 years ago
Closed 10 years ago
#4063 defect closed fixed (fixed)
Ween trial's --dry-run away from the deprecated TestCase.visitor code.
| Reported by: | kelly | Owned by: | |
|---|---|---|---|
| Priority: | normal | Milestone: | |
| Component: | trial | Keywords: | |
| Cc: | Thijs Triemstra | Branch: |
branches/dry-run-4063
branch-diff, diff-cov, branch-cov, buildbot |
| Author: | kelly, thijs |
Description
t.t.runner.TrialRunner is still using the deprecated visitor code to do --dry-run.
Attachments (1)
Change History (11)
Changed 10 years ago by
| Attachment: | fix-dry-run.patch added |
|---|
comment:1 Changed 10 years ago by
| Author: | → thijs |
|---|---|
| Branch: | → branches/dry-run-4063 |
comment:2 Changed 10 years ago by
| Author: | thijs → kelly, thijs |
|---|---|
| Cc: | Thijs Triemstra added |
Thanks kelly, I branched in r27435
comment:4 Changed 10 years ago by
| Keywords: | review removed |
|---|---|
| Owner: | changed from Jonathan Lange to Thijs Triemstra |
There's already a method that does this called _iterateTests, which lives in twisted.trial.util. Can you please simply change dry-run to use that?
comment:5 Changed 10 years ago by
| Owner: | changed from Thijs Triemstra to Jean-Paul Calderone |
|---|---|
| Status: | new → assigned |
comment:7 Changed 10 years ago by
| Keywords: | review added |
|---|---|
| Owner: | changed from Jean-Paul Calderone to Jonathan Lange |
| Status: | assigned → new |
comment:8 Changed 10 years ago by
| Keywords: | review removed |
|---|---|
| Owner: | changed from Jonathan Lange to Jean-Paul Calderone |
Thanks Jean-Paul! Please land this with my blessing.
Thanks to kelly & thijs too.
comment:9 Changed 10 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
comment:10 Changed 9 years ago by
| Owner: | Jean-Paul Calderone deleted |
|---|
Note: See
TracTickets for help on using
tickets.
(In [27434]) Branching to 'dry-run-4063'