Opened 11 years ago

Closed 11 years ago

#3990 defect closed fixed (fixed)

There are a number of duplicate simplistic fake IReactorTCP implementations spread throughout the test suite

Reported by: Jean-Paul Calderone Owned by:
Priority: normal Milestone:
Component: core Keywords:
Cc: Branch: branches/one-fake-reactor-3990
branch-diff, diff-cov, branch-cov, buildbot
Author: exarkun

Description

These implementations should be unified into a single implementation. Hopefully that implementation can then grow into a more real thing, offering more of the expected behavior of IReactorTCP and perhaps even some of the other reactor interfaces.

(Someday maybe it can even move out of the test suite and be a real thing.)

Change History (5)

comment:1 Changed 11 years ago by Jean-Paul Calderone

Author: exarkun
Branch: branches/one-fake-reactor-3990

(In [27255]) Branching to 'one-fake-reactor-3990'

comment:2 Changed 11 years ago by Jean-Paul Calderone

Keywords: review added
Owner: Jean-Paul Calderone deleted

I consolidated things a bit.

comment:3 Changed 11 years ago by Jonathan Jacobs

Keywords: review removed
Owner: set to Jean-Paul Calderone

Looks good, go ahead and merge.

comment:4 Changed 11 years ago by Jean-Paul Calderone

Resolution: fixed
Status: newclosed

(In [27260]) Merge one-fake-reactor-3990

Author: exarkun Reviewer: jonathanj Fixes: #3990

Merge the several partial implementations of IReactorTCP in various test modules into a single implementation in twisted.test.proto_helpers.

comment:5 Changed 9 years ago by <automation>

Owner: Jean-Paul Calderone deleted
Note: See TracTickets for help on using tickets.