Opened 12 years ago

Closed 12 years ago

#3895 defect closed fixed (fixed)

twisted.words.protocols.irc.IRCClient.mode docstring claims "#" will be prepended to channel name if it is not already there, but it will not be

Reported by: Jean-Paul Calderone Owned by:
Priority: normal Milestone:
Component: words Keywords: documentation easy
Cc: Branch:
Author:

Description

This part of the docstring should just be deleted, I think. As far as I can tell, this was never the behavior of this API.

Attachments (1)

words-protocols-irc-IRCClient-mode.patch​ (658 bytes) - added by jesstess 12 years ago.

Download all attachments as: .zip

Change History (6)

Changed 12 years ago by jesstess

Attachment: words-protocols-irc-IRCClient-mode.patch​ added

comment:1 Changed 12 years ago by jesstess

Keywords: review added
Owner: Jean-Paul Calderone deleted

comment:2 Changed 12 years ago by ivank

I looked very closely at irc.py. The patch looks correct. Someone with SVN access should merge. I'm leaving the review keyword so that this doesn't get lost.

comment:3 Changed 12 years ago by Jean-Paul Calderone

Keywords: review removed
Owner: set to Jean-Paul Calderone

Thanks. You should probably remove the review keyword for this sort of thing in the future, or at least assign the ticket to a committer. Also, would you like commit access?

comment:4 Changed 12 years ago by Jean-Paul Calderone

Resolution: → fixed
Status: new → closed

(In [27231]) Apply words-protocols-irc-IRCClient-mode.patch fixing misinformation in IRCClient.mode docstring

Author: jesstess Reviewer: ivank Fixes: #3895

Remove the lies in IRCClient.mode's docstring which claimed non-channel targets would be forced to be channels.

comment:5 Changed 10 years ago by <automation>

Owner: Jean-Paul Calderone deleted
Note: See TracTickets for help on using tickets.