Opened 11 years ago

Closed 10 years ago

#3849 enhancement closed fixed (fixed)

twisted.conch.client.knownhosts uses Crypto.Hash.HMAC, could easily use stdlib hmac instead

Reported by: Jean-Paul Calderone Owned by:
Priority: low Milestone:
Component: conch Keywords: easy
Cc: Branch: branches/conch-hmac-3849
branch-diff, diff-cov, branch-cov, buildbot
Author: therve

Description

The former of these two is actually a fork of the latter. Just switching knownhosts to the stdlib version won't make any part of Conch work without PyCrypto, but I still don't see a particularly good reason to use the PyCrypto version of this library rather than the stdlib version.

Attachments (1)

stdlib_hmac.patch (703 bytes) - added by jtanis 10 years ago.
Replaced Crypto.Hash.HMAC with stdlib hmac as stated

Download all attachments as: .zip

Change History (9)

Changed 10 years ago by jtanis

Attachment: stdlib_hmac.patch added

Replaced Crypto.Hash.HMAC with stdlib hmac as stated

comment:1 Changed 10 years ago by jtanis

Keywords: review added
Owner: changed from z3p to jtanis
Status: newassigned

comment:2 Changed 10 years ago by jtanis

Owner: jtanis deleted
Status: assignednew

comment:3 Changed 10 years ago by therve

Author: therve
Branch: branches/conch-hmac-3849

(In [28343]) Branching to 'conch-hmac-3849'

comment:4 Changed 10 years ago by therve

Owner: set to therve

comment:5 Changed 10 years ago by therve

Owner: therve deleted

comment:6 Changed 10 years ago by terrycojones

Keywords: review removed

Looks good. trial twisted passes.

comment:7 Changed 10 years ago by therve

Resolution: fixed
Status: newclosed

(In [28407]) Merge conch-hmac-3849

Authors: jtanis, therve Reviewer: terrycojones Fixes #3849

Remove usage of Crypto.Hash from twisted.conch.client.

comment:8 Changed 9 years ago by <automation>

Note: See TracTickets for help on using tickets.