Opened 13 years ago

Last modified 10 years ago

#3843 task new

deprecate twisted.persisted

Reported by: Jean-Paul Calderone Owned by:
Priority: high Milestone:
Component: core Keywords:
Cc: Ying Li, Thijs Triemstra Branch:

Description (last modified by Thijs Triemstra)

The things remaining in the twisted.persisted fall into two general categories:

  • persistence libraries
  • utilities useful in combination with a persistence library
    • sob
    • crefutil
    • styles

Of these, the former are used nowhere in Twisted and are generally either not suitable for use at all (dirdbm, journal) or do not present compelling features (aot), whereas the latter see some use in Twisted but provide extremely marginal functionality (or pseudo-functionality - for example, styles primarily provides Versioned, a class which supposedly offers an upgrade path for pickled objects, the in memory representation of which changes over time, we have long since abandoned the attempt to maintain this upgrade path) which can easily be dropped.

I propose to remove all uses of the package from the remainder of Twisted and then deprecate the entire package.

Change History (6)

comment:1 Changed 12 years ago by Glyph

Owner: changed from Glyph to radix

Reassigning as a penance for AOT.

comment:2 in reply to:  1 Changed 12 years ago by Thijs Triemstra

Cc: Ying Li Thijs Triemstra added

Replying to glyph:

Reassigning as a penance for AOT.

Say what?? :)

comment:3 Changed 12 years ago by Glyph

radix implemented the 'aot' or "abstract object tree" serialization mechanism in twisted.persisted (also known as "python source-code dump serialization") which is one of the worse things in there. That and 'marmalade' (XML pickling) were two approaches that were known to be a bad idea even at the time of their implementation :). I was suggesting that he do this work as part of his rehabilitation.

Whoever deprecates this should be careful to remove any internal uses in Twisted. In particular, I believe that things in PB still subclass some things in styles.

comment:4 Changed 11 years ago by <automation>

Owner: radix deleted

comment:5 Changed 10 years ago by Thijs Triemstra

Description: modified (diff)

comment:6 Changed 10 years ago by Thijs Triemstra

Description: modified (diff)
Note: See TracTickets for help on using tickets.