twisted.internet.posixbase._Waker not defined on Jython

[pjenvey]

posixbase defines a _Waker depending on the value of twisted.python.runtime.platformType, which is 'java' on Jython. There's no _Waker definition for 'java'

$ jython -W all ./bin/trial --reporter=bwverbose --unclean-warnings twisted
<snip>
Traceback (most recent call last):
  File "./bin/trial", line 24, in <module>
    run()
  File "/Users/pjenvey/src/java/jython/jython-twisted/src/Twisted/twisted/scripts/trial.py", line 361, in run
    test_result = trialRunner.run(suite)
  File "/Users/pjenvey/src/java/jython/jython-twisted/src/Twisted/twisted/trial/runner.py", line 813, in run
    return self._runWithoutDecoration(test)
  File "/Users/pjenvey/src/java/jython/jython-twisted/src/Twisted/twisted/trial/runner.py", line 839, in _runWithoutDecoration
    run()
  File "/Users/pjenvey/src/java/jython/jython-twisted/src/Twisted/twisted/trial/runner.py", line 834, in <lambda>
    run = lambda: suite.run(result)
  File "/Users/pjenvey/src/java/jython/jython-twisted/src/Twisted/twisted/trial/runner.py", line 293, in run
    self._bail()
  File "/Users/pjenvey/src/java/jython/jython-twisted/src/Twisted/twisted/trial/runner.py", line 275, in _bail
    from twisted.internet import reactor
  File "/Users/pjenvey/src/java/jython/jython-twisted/src/Twisted/twisted/internet/reactor.py", line 38, in <module>
    selectreactor.install()
  File "/Users/pjenvey/src/java/jython/jython-twisted/src/Twisted/twisted/internet/selectreactor.py", line 200, in install
    reactor = SelectReactor()
  File "/Users/pjenvey/src/java/jython/jython-twisted/src/Twisted/twisted/internet/selectreactor.py", line 72, in __init__
    posixbase.PosixReactorBase.__init__(self)
  File "/Users/pjenvey/src/java/jython/jython-twisted/src/Twisted/twisted/internet/posixbase.py", line 168, in __init__
    ReactorBase.__init__(self)
  File "/Users/pjenvey/src/java/jython/jython-twisted/src/Twisted/twisted/internet/base.py", line 467, in __init__
    self._initThreads()
  File "/Users/pjenvey/src/java/jython/jython-twisted/src/Twisted/twisted/internet/base.py", line 887, in _initThreads
    self.installWaker()
  File "/Users/pjenvey/src/java/jython/jython-twisted/src/Twisted/twisted/internet/posixbase.py", line 204, in installWaker
    self.waker = _Waker(self)
NameError: global name '_Waker' is not defined

[thijs]

Updating ticket description, fixing typo (Waker instead of Walker)

[thijs]

The buildslave is ​reporting the same error message now.

[sanxiyn]

Please review.

[sanxiyn]

Oops, os.pipe is present on win32. Is "I am a workaround for the lack of pipes on win32" accurate?

[therve]

Yeah, pipes are available on windows, but are not selectable (iirc). So you need to check for something else, unfortunately. And indeed the docstring of Win32Waker should be updated.

[exarkun]

(In [28218]) Branching to 'jython-waker-3718'

[exarkun]

(In [28219]) Use the newly renamed _SocketWaker on Windows, _PipeWaker everywhere else

refs #3718

[exarkun]

Fixed some of that stuff. Jython can ​run the tests in the branch.

[thijs]

I{self-pipe trick<​http://cr.yp.to/docs/selfpipe.html>} should probably use U instead of I.

[thijs]

Replying to exarkun:

Fixed some of that stuff. Jython can ​run the tests in the branch.

Trial is dying with:

Exception in thread "MainThread" java.lang.OutOfMemoryError: Java heap space

Exarkun, could you increase the memory? From #jython:

pjenvey: default is 512mb, you can do jython -J-Xmx1024m
pjenvey: JAVA_MEM=-Xmx1024m jython should work too

[thijs]

I see you added a 1024, but looks like it's still ​not enough. Can you double it?

[thijs]

I just ran it (on that buildslave) with 2048 and it still fails. I guess the buildslave, or jython support, is not an option until we take a look at trial's memory usage.

[exarkun]

One possible explanation for the memory usage is that all the failures trial is keeping around are responsible. This might be helped by throwing away the actual failures and just keeping the string that will be reported at the end.

If this is the cause, then another possible work-around would be to run a limited subset of the tests on Jython until those all pass, then expand that set and repeat.

[exarkun]

I set up the builder to just run twisted.test for now. Let's see ​what happens...

[therve]

Looks better, I guess. +1.

[exarkun]

(In [28292]) Merge jython-waker-3718

Author: sanxiyn, exarkun Reviewer: therve Fixes: #3718

Change the waker selection code to be aware of non-Windows, non-POSIX platforms (such as Java/Jython).