Opened 10 years ago

Closed 10 years ago

Last modified 10 years ago

#3714 enhancement closed fixed (fixed)

Delete the __main__ in twisted/protocols/shoutcast.py

Reported by: Jean-Paul Calderone Owned by:
Priority: normal Milestone:
Component: core Keywords: easy
Cc: Thijs Triemstra, radix Branch: branches/shoutcast-main-3714
branch-diff, diff-cov, branch-cov, buildbot
Author: cary, thijs

Description

This shouldn't be a script. We can add a separate client that does shoutcast stuff later if we want.

Attachments (1)

shoutcast.patch (658 bytes) - added by cary 10 years ago.

Download all attachments as: .zip

Change History (12)

Changed 10 years ago by cary

Attachment: shoutcast.patch added

comment:1 Changed 10 years ago by cary

Keywords: review added
Owner: Glyph deleted

comment:2 Changed 10 years ago by Thijs Triemstra

Cc: Thijs Triemstra added
Keywords: review removed
Owner: set to Thijs Triemstra
Status: newassigned

Thanks for the patch. I think it could be used as an example if there's not one for shoutcast already.

comment:3 Changed 10 years ago by Thijs Triemstra

Author: thijs
Branch: branches/shoutcast-main-3714

(In [26549]) Branching to 'shoutcast-main-3714'

comment:4 Changed 10 years ago by Thijs Triemstra

(In [26550]) Apply shoutcast.patch refs #3714

comment:5 Changed 10 years ago by Thijs Triemstra

(In [26551]) Add shoutcast client example refs #3714

comment:6 Changed 10 years ago by Thijs Triemstra

Keywords: review added
Owner: Thijs Triemstra deleted
Status: assignednew

comment:7 Changed 10 years ago by Jean-Paul Calderone

Keywords: review removed
Owner: set to Jean-Paul Calderone

Looks good to me

comment:8 Changed 10 years ago by Jean-Paul Calderone

Author: thijscory, thijs
Cc: radix added

Oops. Actually, shoutcast depends on twisted.web! I guess I'll merge this anyway, since it's still an improvement, but we're going to need to move shoutcast into the Twisted Web package (module moved for split ha ha).

comment:9 Changed 10 years ago by Jean-Paul Calderone

Resolution: fixed
Status: newclosed

(In [26572]) Merge shoutcast-main-3714

Author: cary, thijs Reviewer: exarkun Fixes: #3714

Move the __main__ out of twisted/protocols/shoutcast.py and into an example script.

comment:10 Changed 10 years ago by Jean-Paul Calderone

Author: cory, thijscary, thijs

comment:11 Changed 8 years ago by <automation>

Owner: Jean-Paul Calderone deleted
Note: See TracTickets for help on using tickets.