Opened 8 years ago

Closed 8 years ago

#3712 enhancement closed fixed (fixed)

Delete the __main__ in twisted/names/root.py

Reported by: Jean-Paul Calderone Owned by:
Priority: normal Milestone:
Component: names Keywords: easy
Cc: Thijs Triemstra Branch: branches/root-main-3712
branch-diff, diff-cov, branch-cov, buildbot
Author: thijs, cary

Description

This file isn't meant to be used as a script. There are also no tests for this behavior. Also it's using a soon-to-be-deprecated API. We can add a real script to do name resolution with twisted.names later, if we want.

Attachments (1)

root.patch (718 bytes) - added by cary 8 years ago.

Download all attachments as: .zip

Change History (10)

Changed 8 years ago by cary

Attachment: root.patch added

comment:1 Changed 8 years ago by cary

Keywords: review added
Owner: Jean-Paul Calderone deleted

comment:2 Changed 8 years ago by Thijs Triemstra

Author: thijs
Branch: branches/root-main-3712

(In [26552]) Branching to 'root-main-3712'

comment:3 Changed 8 years ago by Thijs Triemstra

(In [26553]) Apply root.patch, refs #3712

comment:4 Changed 8 years ago by Thijs Triemstra

Author: thijsthijs, cary
Cc: Thijs Triemstra added
Keywords: review removed
Owner: set to Thijs Triemstra
Status: newassigned

comment:5 Changed 8 years ago by Thijs Triemstra

Keywords: review added
Owner: Thijs Triemstra deleted
Status: assignednew

comment:6 Changed 8 years ago by Jean-Paul Calderone

Keywords: review removed
Owner: set to Jean-Paul Calderone

Looks good. I'm going to make a couple minor coding standard updates to the changed file.

comment:7 Changed 8 years ago by Jean-Paul Calderone

(In [26565]) Update copyright date, remove unused imports

refs #3712

comment:8 Changed 8 years ago by Jean-Paul Calderone

Resolution: fixed
Status: newclosed

(In [26569]) Merge root-main-3712

Author: cary Reviewer: thijs, exarkun Fixes: #3712

Remove the __main__ from twisted/names/root.py.

comment:9 Changed 7 years ago by <automation>

Owner: Jean-Paul Calderone deleted
Note: See TracTickets for help on using tickets.