Opened 8 years ago
Closed 8 years ago
#3712 enhancement closed fixed (fixed)
Delete the __main__ in twisted/names/root.py
| Reported by: | Jean-Paul Calderone | Owned by: | |
|---|---|---|---|
| Priority: | normal | Milestone: | |
| Component: | names | Keywords: | easy |
| Cc: | Thijs Triemstra | Branch: |
branches/root-main-3712
branch-diff, diff-cov, branch-cov, buildbot |
| Author: | thijs, cary |
Description
This file isn't meant to be used as a script. There are also no tests for this behavior. Also it's using a soon-to-be-deprecated API. We can add a real script to do name resolution with twisted.names later, if we want.
Attachments (1)
Change History (10)
Changed 8 years ago by
| Attachment: | root.patch added |
|---|
comment:1 Changed 8 years ago by
| Keywords: | review added |
|---|---|
| Owner: | Jean-Paul Calderone deleted |
comment:2 Changed 8 years ago by
| Author: | → thijs |
|---|---|
| Branch: | → branches/root-main-3712 |
comment:4 Changed 8 years ago by
| Author: | thijs → thijs, cary |
|---|---|
| Cc: | Thijs Triemstra added |
| Keywords: | review removed |
| Owner: | set to Thijs Triemstra |
| Status: | new → assigned |
comment:5 Changed 8 years ago by
| Keywords: | review added |
|---|---|
| Owner: | Thijs Triemstra deleted |
| Status: | assigned → new |
comment:6 Changed 8 years ago by
| Keywords: | review removed |
|---|---|
| Owner: | set to Jean-Paul Calderone |
Looks good. I'm going to make a couple minor coding standard updates to the changed file.
comment:7 Changed 8 years ago by
comment:8 Changed 8 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
comment:9 Changed 7 years ago by
| Owner: | Jean-Paul Calderone deleted |
|---|
Note: See
TracTickets for help on using
tickets.
(In [26552]) Branching to 'root-main-3712'