Opened 8 years ago

Closed 8 years ago

#3712 enhancement closed fixed (fixed)

Delete the __main__ in twisted/names/root.py

Reported by: exarkun Owned by:
Priority: normal Milestone:
Component: names Keywords: easy
Cc: thijs Branch: branches/root-main-3712
branch-diff, diff-cov, branch-cov, buildbot
Author: thijs, cary

Description

This file isn't meant to be used as a script. There are also no tests for this behavior. Also it's using a soon-to-be-deprecated API. We can add a real script to do name resolution with twisted.names later, if we want.

Attachments (1)

root.patch​ (718 bytes) - added by cary 8 years ago.

Download all attachments as: .zip

Change History (10)

Changed 8 years ago by cary

comment:1 Changed 8 years ago by cary

  • Keywords review added
  • Owner exarkun deleted

comment:2 Changed 8 years ago by thijs

  • Author set to thijs
  • Branch set to branches/root-main-3712

(In [26552]) Branching to 'root-main-3712'

comment:3 Changed 8 years ago by thijs

(In [26553]) Apply root.patch, refs #3712

comment:4 Changed 8 years ago by thijs

  • Author changed from thijs to thijs, cary
  • Cc thijs added
  • Keywords review removed
  • Owner set to thijs
  • Status changed from new to assigned

comment:5 Changed 8 years ago by thijs

  • Keywords review added
  • Owner thijs deleted
  • Status changed from assigned to new

comment:6 Changed 8 years ago by exarkun

  • Keywords review removed
  • Owner set to exarkun

Looks good. I'm going to make a couple minor coding standard updates to the changed file.

comment:7 Changed 8 years ago by exarkun

(In [26565]) Update copyright date, remove unused imports

refs #3712

comment:8 Changed 8 years ago by exarkun

  • Resolution set to fixed
  • Status changed from new to closed

(In [26569]) Merge root-main-3712

Author: cary Reviewer: thijs, exarkun Fixes: #3712

Remove the __main__ from twisted/names/root.py.

comment:9 Changed 6 years ago by <automation>

  • Owner exarkun deleted
Note: See TracTickets for help on using tickets.