Opened 8 years ago

Closed 8 years ago

#3710 enhancement closed fixed (fixed)

deprecate twisted.names.client.ThreadedResolver in favor of twisted.internet.base.ThreadedResolver

Reported by: Jean-Paul Calderone Owned by:
Priority: normal Milestone:
Component: names Keywords: deprecation
Cc: Branch: branches/deprecate-threadedresolver-3710
branch-diff, diff-cov, branch-cov, buildbot
Author: cary, exarkun

Description

We've basically decided that twisted.internet.base.ThreadedResolver is public now, despite the slight unfortunateness that implies. So we can just point people at that.

Attachments (1)

client.patch (807 bytes) - added by cary 8 years ago.

Download all attachments as: .zip

Change History (12)

comment:1 Changed 8 years ago by cary

Keywords: review added
Owner: Jean-Paul Calderone deleted

Changed 8 years ago by cary

Attachment: client.patch added

comment:2 Changed 8 years ago by cary

Keywords: deprecation added
Owner: set to David Reid

comment:3 Changed 8 years ago by Jean-Paul Calderone

Keywords: review removed
Owner: changed from David Reid to Jean-Paul Calderone

This should have a test, too.

comment:4 Changed 8 years ago by Jean-Paul Calderone

Author: exarkun
Branch: branches/deprecate-threadedresolver-3710

(In [26638]) Branching to 'deprecate-threadedresolver-3710'

comment:5 Changed 8 years ago by Jean-Paul Calderone

(In [26639]) Apply cary's patch to deprecate ThreadedResolver

refs #3710

comment:6 Changed 8 years ago by Jean-Paul Calderone

(In [26640]) test the deprecation; make it be the right type and point at the right code

refs #3710

comment:7 Changed 8 years ago by Jean-Paul Calderone

Keywords: review added
Owner: Jean-Paul Calderone deleted

comment:8 Changed 8 years ago by Jean-Paul Calderone

Author: exarkuncary, exarkun

comment:9 Changed 8 years ago by therve

Keywords: review removed
Owner: set to Jean-Paul Calderone

Cool, please merge.

comment:10 Changed 8 years ago by Jean-Paul Calderone

Resolution: fixed
Status: newclosed

(In [26656]) Merge deprecate-threadedresolver-3710

Author: cary, exarkun Reviewer: therve Fixes: #3710

Deprecate twisted.names.client.ThreadedResolver in favor of twisted.internet.base.ThreadedResolver.

comment:11 Changed 7 years ago by <automation>

Owner: Jean-Paul Calderone deleted
Note: See TracTickets for help on using tickets.