Changes between and of Initial VersionVersion 1Ticket #3696, comment 76


Ignore:
Timestamp:
01/25/2015 12:50:33 PM (5 years ago)
Author:
Chris Wolfe
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #3696, comment 76

    initial v1  
    1 Glyph - thanks for your review!
    2 
    3 I believe I've fixed the twistedchecker errors - the constants are now ALL_CAPS_WITH_UNDERSCORES and there are now three lines separating the new test class from the old.
    4 
    5 In order to avoid the hard dependency on setuptools, I've setup the tests to attempt to import setuptools. If it is available, the tests run. If it isn't then the extras_require tests are skipped.
    6 
    7 Twisted.python.dist only depends on distutils.core.Distribution being available. If setuptools is installed, this object will be replaced with a setuptools.Distribution object that supports the extra options. If only distutils is available, the extra options won't function.
    8 
    9 The patch https://twistedmatrix.com/trac/attachment/ticket/3696/extras_require-3696-14.diff should address all of the issues.
    10 
    11 Thanks!
    12 
    13 
    14 
    15