Opened 11 years ago

Closed 11 years ago

#3686 enhancement closed fixed (fixed)

ProtocolWrapper should jam itself in as the transport in makeConnection, not connectionMade.

Reported by: Michael Hudson-Doyle Owned by:
Priority: normal Milestone:
Component: core Keywords:
Cc: Branch: branches/protocolwrapper-makeconnection-3686
branch-diff, diff-cov, branch-cov, buildbot
Author: exarkun


Arguably, anyway.

Change History (7)

comment:1 Changed 11 years ago by Jean-Paul Calderone

By overriding connectionMade instead, ProtocolWrapper is not precisely adhering to IProtocol. It probably shouldn't have a connectionMade at all, just a makeConnection which does everything.

comment:2 Changed 11 years ago by Jean-Paul Calderone

Author: exarkun
Branch: branches/protocolwrapper-makeconnection-3686

(In [26377]) Branching to 'protocolwrapper-makeconnection-3686'

comment:3 Changed 11 years ago by Jean-Paul Calderone

(In [26378]) Drop ProtocolWrapper.connectionMade in favor of a more complete ProtocolWrapper.makeConnection

As a bonus, also get rid of some other cruft.

refs #3686

comment:4 Changed 11 years ago by Jean-Paul Calderone

Keywords: review added
Owner: Glyph deleted

comment:5 Changed 11 years ago by Michael Hudson-Doyle

Keywords: review removed
Owner: set to Jean-Paul Calderone

Looks fine.

I don't understand how test_transportInterfaces still passes, but it does, so...

comment:6 Changed 11 years ago by Jean-Paul Calderone

Resolution: fixed
Status: newclosed

(In [26426]) Merge protocolwrapper-makeconnection-3686

Author: exarkun Reviewer: mwhudson Fixes: #3686

Simplify ProtocolWrapper by consolidating its setup code in its makeConnection method. Also remove the redundant directlyProvides call it makes (redundant because __getattr__ causes it to provide the interfaces of the wrapped transport already). Also improve test coverage and remove a redundant test helper.

comment:7 Changed 9 years ago by <automation>

Owner: Jean-Paul Calderone deleted
Note: See TracTickets for help on using tickets.