Opened 12 years ago

Last modified 12 years ago

#3650 defect new

iocpreactor/tcp.py doConnect may call cbConnect with too many arguments

Reported by: ivank Owned by: PenguinOfDoom
Priority: normal Milestone:
Component: core Keywords: iocpreactor
Cc: Branch:
Author:

Description

This was found by static analysis, not a real program. I don't think this behavior is unit-tested anywhere, and I have no idea what is actually going on.

Line 223 of twisted/internet/iocpreactor/tcp.py: self.cbConnect(rc, 0, 0, evt)

Yet self.cbConnect is cbConnect(self, rc, bytes, evt) and takes 4 arguments, not 5.

Change History (1)

comment:1 Changed 12 years ago by Jean-Paul Calderone

Owner: changed from Glyph to PenguinOfDoom

This looks like it might be the code for a synchronous connection success? Or perhaps due to a synchronous connection failure?

Note: See TracTickets for help on using tickets.