If the Content-Type of a request is "application/x-www-form-urlencoded", twisted.web.wsgi gives applications a zero-length input object

[wangchun]

Sometimes twisted.web.http.Request.requestReceived reads from the body object (Request.content) and parses the result into Request.args. Then it calls process. If a twisted.web.wsgi.WSGIResource is getting the request, it will be passed on as the wsgi.input in the environ to application code. This means that sometimes a wsgi application will get an already-read input and not be able to get the request body.

[Jean-Paul Calderone]

Adjusting summary and description to more directly describe the problem, rather than describing a possible solution. The old description was:

This causes problem with the recently added twisted.web.wsgi.

If a POST Request's Content-Type equals to 'application/x-www-form-urlencoded', calling environwsgi.input?.read(...) in a wsgi app will return empty string since it had been read before in the Twisted framework.

Patch attached.

[mattc]

wangchun's fix seems fine to me. What's the next step?

[Jean-Paul Calderone]

There need to be unit tests to go along with the fix.

[mattc]

fix with test coverage

[mattc]

Attached a fix with test coverage.

[Jean-Paul Calderone]

The patch basically looks good to me. I've adjusted it a bit to deal with trivial coding standard issues and to be less specific in the prediction added to the unit tests, though.

[Jean-Paul Calderone]

(In [26120]) Branching to 'wsgi-form-post-3585'

[Jean-Paul Calderone]

(In [26121]) Apply slightly modified version of mattc's patch

refs #3585

[Jean-Paul Calderone]

(In [26123]) Merge wsgi-form-post-3585

Author: mattc, exarkun Reviewer: exarkun Fixes: #3585

Ensure that Request.content is always positioned at the beginning of the file before calling the process method. This simplifies handling request bodies by making it never necessary to explicitly seek back to the beginning of the file.

[Jean-Paul Calderone]

#4070 was a duplicate of this.