Opened 13 years ago

Closed 13 years ago

#3547 defect closed fixed (fixed)

StringListMailbox has no unit tests

Reported by: Wilfredo Sánchez Vega Owned by:
Priority: normal Milestone:
Component: mail Keywords:
Cc: Branch: branches/stringlistmailbox-tests-3547
branch-diff, diff-cov, branch-cov, buildbot
Author: exarkun

Description

In twisted/mail/maildir.py, StringListMailbox has no unit tests

Change History (7)

comment:1 Changed 13 years ago by Jean-Paul Calderone

Component: coremail
Owner: changed from Glyph to Jean-Paul Calderone
Type: enhancementdefect

comment:2 Changed 13 years ago by Jean-Paul Calderone

Author: exarkun
Branch: branches/stringlistmailbox-tests-3547

(In [25424]) Branching to 'stringlistmailbox-tests-3547'

comment:3 Changed 13 years ago by Jean-Paul Calderone

Keywords: review added
Owner: Jean-Paul Calderone deleted

comment:4 Changed 13 years ago by therve

Keywords: review removed
Owner: set to Jean-Paul Calderone

Please merge after fixing those flakes:

twisted/mail/maildir.py:15: 'cStringIO' imported but unused
twisted/mail/maildir.py:31: 'alias' imported but unused

comment:5 Changed 13 years ago by Jean-Paul Calderone

(In [25446]) Remove unused imports

refs #3547

comment:6 Changed 13 years ago by Jean-Paul Calderone

Resolution: fixed
Status: newclosed

(In [25447]) Merge stringlistmailbox-tests-3547

Author: exarkun Reviewer: therve Fixes: #3547

Add unit tests for twisted.mail.maildir.StringListMailbox and fix the implementation to support deletion, undeletion, and syncing.

comment:7 Changed 11 years ago by <automation>

Owner: Jean-Paul Calderone deleted
Note: See TracTickets for help on using tickets.