Opened 13 years ago

Closed 13 years ago

#3467 defect closed fixed (fixed)

t.w.p.j.xmlstream.toResponse's test for the presence of a stanzaType is faulty.

Reported by: Ralph Meijer Owned by:
Priority: normal Milestone:
Component: words Keywords:
Cc: Branch: branches/jabber-toResponse-3467
branch-diff, diff-cov, branch-cov, buildbot
Author: ralphm


Instead of looking for stanzaType it tests for type, which is always there.

Change History (5)

comment:1 Changed 13 years ago by Ralph Meijer

author: ralphm
Branch: branches/jabber-toResponse-3467

(In [24968]) Branching to 'jabber-toResponse-3467'

comment:2 Changed 13 years ago by Ralph Meijer

Keywords: review added
Owner: Ralph Meijer deleted

Easy fix. Please review.

comment:3 Changed 13 years ago by therve

Keywords: review removed
Owner: set to Ralph Meijer

Instead of using self.failIf, please use self.assertFalse. You can then merge, thanks.

comment:4 Changed 13 years ago by Ralph Meijer

Resolution: fixed
Status: newclosed

(In [24975]) Ensure toResponse generates a valid stanza if the stanzaType was not specified.

Author: ralphm. Reviewer: therve. Fixes #3467.

comment:5 Changed 11 years ago by <automation>

Owner: Ralph Meijer deleted
Note: See TracTickets for help on using tickets.