Opened 10 years ago

Closed 10 years ago

#3370 defect closed fixed (fixed)

twisted.internet.test.reactormixins.ReactorBuilder.runReactor leaks state on glib2 and gtk2

Reported by: Jean-Paul Calderone Owned by:
Priority: highest Milestone:
Component: core Keywords:
Cc: Branch: branches/reactorbuilder-cleanup-more-3370
branch-diff, diff-cov, branch-cov, buildbot
Author: exarkun


It seems glib2 and gtk2 reactors live forever and can interfer with later tests. ReactorBuilder needs to do some extra work to clean these up, perhaps by cancelling all their outstanding DelayedCalls.

Change History (6)

comment:1 Changed 10 years ago by Jean-Paul Calderone

author: exarkun
Branch: branches/reactorbuilder-cleanup-more-3370

(In [24405]) Branching to 'reactorbuilder-cleanup-more-3370'

comment:2 Changed 10 years ago by Jean-Paul Calderone

Keywords: review added
Owner: Jean-Paul Calderone deleted
Priority: highhighest

Okay, should be fixed. You can observe the problem by running trial -u twisted.internet.test.test_tls and letting it go for two minutes. It will die right around the two minute mark. It should run indefinitely with the changes in the branch.

comment:3 Changed 10 years ago by washort

Owner: set to Jean-Paul Calderone

I get the same results here. Looks good to merge.

comment:4 Changed 10 years ago by washort

Keywords: review removed

comment:5 Changed 10 years ago by Jean-Paul Calderone

Resolution: fixed
Status: newclosed

(In [24419]) Merge reactorbuilder-cleanup-more-3370

Author: exarkun Reviewer: washort Fixes: #3370

Add code to cancel all pending timed events to the reactor cleanup code in twisted.internet.test.reactormixins so that they don't remain to interfere with future tests.

comment:6 Changed 7 years ago by <automation>

Owner: Jean-Paul Calderone deleted
Note: See TracTickets for help on using tickets.