Opened 15 years ago
Last modified 3 years ago
#308 defect closed fixed (fixed)
Bug in the webmonitor.py example that causes just one iteration and then stops
| Reported by: | lstep | Owned by: | |
|---|---|---|---|
| Priority: | high | Milestone: | |
| Component: | conch | Keywords: | |
| Cc: | lstep, Moshe Zadka | Branch: | |
| Author: |
Description
Change History (4)
comment:1 Changed 15 years ago by
comment:2 Changed 15 years ago by
Checking in twisted/web/monitor.py; /cvs/Twisted/twisted/web/monitor.py,v <-- monitor.py new revision: 1.7; previous revision: 1.6 done Fixed [By enhancing BaseChange]
comment:3 Changed 8 years ago by
| Owner: | Moshe Zadka deleted |
|---|
Note: See
TracTickets for help on using
tickets.
The webmonitor.py example, when run, connects just once to the remote web server, and then do nothing. The problem is that in the example there is no reportNoChange() method in the ChangeNotified class. So when the ChangeChecker is called and that there is no change on the page (most usual :), it tries to call self.notified.reportNoChange() which doesn't exist ! So it "crashes" silently, and you think monitor is working... To correct this, just add:: def reportNoChange(self): pass in the ChangeNotified class of the webmonitor.py example file. To be more clean, I suggest to add a test for the presence of the methods reportNoChange() and reportChange() in t.w.monitor module.