imap relies on a C locale for date formatting

[therve]

spew_internaldate uses time.strftime, which is locale dependant. It should use something not relying on the locale.

The problem can be reproduce by running the imap test suite with gtk2 reactor and a non english locale (like fr_FR).

[Jean-Paul Calderone]

This is actually a bug in the implementation of date formatting, not in the tests. The resulting string should not vary depending on the locale of the server environment.

[therve]

Yeah it seems so. I've looked at the RFC (​http://www.faqs.org/rfcs/rfc3501.html), and the format date-time uses date-month, and date-month explicitly lists the month in english abbreviated format.

[moijes12]

So, if someone were to start working on this, where does he begin ?

[Jean-Paul Calderone]

Thanks for your interest in this ticket, moijes12. Can you explain what you're asking in more detail? Superficially, it seems like this ticket describes the issue in pretty good detail.

[argonemyth]

From what I read in the method spew_internaldate, someone already fixed the problem and we already have a test for it: test_fetchInternalDateLocaleIndependent.

Here is my local output from trial [trunk r35167]:

$ bin/trial -r gtk2 twisted.mail.test.test_imap.NewFetchTestCase.test_fetchInternalDateLocaleIndependent
twisted.mail.test.test_imap
  NewFetchTestCase
    test_fetchInternalDateLocaleIndependent ...                            [OK]

-------------------------------------------------------------------------------
Ran 1 tests in 0.059s

PASSED (successes=1)

Just to make sure, I changed my locale to fr_FR.utf8 and ran the mail test suite with gtk2 reactor, all tests passed. I am going to close this ticket, if anyone still run into this issue, please re-open the ticket.

[Jean-Paul Calderone]

This was fixed by #4937, which was a duplicate of this ticket. Marking this one as the duplicate, since #4937 is already resolved.