Opened 10 years ago

Closed 7 years ago

#3051 defect closed wontfix (wontfix)

twisted.web2.tap has no unit tests and its longdesc is ugly.

Reported by: David Reid Owned by:
Priority: normal Milestone:
Component: web2 Keywords:
Cc: Thijs Triemstra Branch: branches/web2-tap-tests-3051
branch-diff, diff-cov, branch-cov, buildbot
Author: dreid

Description

It also doesn't have a test-case-name or a copyright notice.

  • It should have unittests written,
  • it's code brought in line with the coding standard,
  • it's longdesc pointing to the HTML documentation for the twistd tap plugin,

Change History (15)

comment:1 Changed 10 years ago by David Reid

Milestone: → Web2-0.3
Status: new → assigned

comment:2 Changed 10 years ago by David Reid

author: → dreid
Branch: → branches/web2-tap-tests-3051

(In [22693]) Branching to 'web2-tap-tests-3051'

comment:3 Changed 10 years ago by David Reid

(In [22694]) Add newlines, remove trailing white space, add a copyright notice, a test-case-name, a bunch of docstrings.

Refs #3051

comment:4 Changed 10 years ago by David Reid

(In [22700]) Tap test cases, fix some bugs involving indexes default value and mimetype.

Refs #3051, #2989

comment:5 Changed 10 years ago by David Reid

(In [22701]) A few more unittests.

Refs #3051

comment:6 Changed 10 years ago by David Reid

(In [22702]) Tests for vhost-path and fix a bug that was exposed.

Refs #3051

comment:7 Changed 10 years ago by David Reid

(In [22703]) More tests.

Refs #3051

comment:8 Changed 10 years ago by David Reid

(In [22704]) More test coverage and stop using os.path.abspath.

Refs #3051

comment:9 Changed 10 years ago by David Reid

(In [22705]) Enclose sys.modules munging in a try-finally

Refs #3051

comment:10 Changed 10 years ago by Glyph

Summary: twisted.web2.tap has no unit tests and it's longdesc is ugly. → twisted.web2.tap has no unit tests and its longdesc is ugly.

​http://angryflower.com/bobsqu.gif

comment:11 Changed 9 years ago by Jean-Paul Calderone

Milestone: Twisted-8.2+1

I can't see any reason this needs to be targeted at 9.0 (8.2+1).

comment:12 Changed 8 years ago by Thijs Triemstra

Cc: Thijs Triemstra added

Why was this branch never put up for review? Unfinished? Guess we can close it with an eye on the TwistedWebPlan.

comment:13 Changed 8 years ago by Jean-Paul Calderone

Might be something from the branch worth porting to twisted.web.tap.

comment:14 Changed 7 years ago by <automation>

Owner: David Reid deleted

comment:15 Changed 7 years ago by washort

Resolution: → wontfix
Status: assigned → closed
Note: See TracTickets for help on using tickets.