Opened 14 years ago

Closed 14 years ago

#3049 defect closed fixed (fixed)

twisted.python.util.mergeFunctionMetadata does not copy __module__ attribute

Reported by: Jean-Paul Calderone Owned by:
Priority: normal Milestone:
Component: core Keywords:
Cc: Branch: branches/mergemodule-3049
branch-diff, diff-cov, branch-cov, buildbot
Author: exarkun

Description

This is an oversight. twisted.python.deprecate currently manually accounts for this, but it is doubtful that other users do.

Change History (5)

comment:1 Changed 14 years ago by Jonathan Lange

Oh, duh. I made some fixes mergeFunctionMetadata in the deprecate branch, but for some reason didn't twig that __module__ should also be copied.

comment:2 Changed 14 years ago by Jean-Paul Calderone

author: exarkun
Branch: branches/mergemodule-3049

(In [22714]) Branching to 'mergemodule-3049'

comment:3 Changed 14 years ago by Jean-Paul Calderone

Keywords: review added
Owner: Glyph deleted

comment:4 Changed 14 years ago by therve

Keywords: review removed

Looks good, please merge.

comment:5 Changed 14 years ago by Jean-Paul Calderone

Resolution: fixed
Status: newclosed

(In [22720]) Merge mergemodule-3049

Author: exarkun Reviewer: therve Fixes #3049

Copy the module attribute from the one function to the other in mergeFunctionMetadata.

Note: See TracTickets for help on using tickets.