Automate version updating (goodly)

[radix]

There should be some first-class code for updating version numbers in a Twisted branch.

[radix]

(In [21717]) Branching to 'change-versions-2885'

[Jonathan Lange]

(In [21731]) Branching to 'change-versions-2885-2'

[Jean-Paul Calderone]

• twisted/python/test/test_dist.py
  • no copyright or module docstring
  • GetVersionTest has no class docstring
• twisted/python/_release.py
  • only the tests use getCurrentVersion - delete it?

Ran out of time on this one, didn't get to look at most of the changes.

[Jonathan Lange]

Updated.

[Jean-Paul Calderone]

It'd be good if all the test methods had docstrings, even the ones which just got moved and not modified (at least in test_release, although it'd be nice to spruce up test_dist as well), since supposedly a goal here is "first class release code".

test_findTwistedStyleProjects and test_getProjectName and test_updateTwistedVersionInformation use twisted and twisted.conch even though they're not operating on the real Twisted source. It might be clearer to use made up names here. test_updateTwistedVersionInformation also doesn't cover the case where baseDirectory is None. There aren't any users of this API either so I can't tell if that is the normal case or not. Maybe those arguments just shouldn't be optional?

replaceProjectVersion writes out a string which refers to admin/change-versions, which no longer exists.

[Jonathan Lange]

• Docstrings added for all test_release tests. Not so concerned about test_dist, since they will likely be heavily modified by the tarball work.
• replaceProjectVersion string changed to no longer refer to admin/change-versions.
• Fixed test_findTwistedStyleProjects, test_getProjectName and test_updateTwistedVersionInformation.

[Jean-Paul Calderone]

• twisted.python.test.test_release.ProjectTest.test_updateTwistedVersionInformation failing
• do something about the XXX in twisted.python._release.getNextVersion
• updateTwistedVersionInformation still has a couple uncovered lines - the ones that handle the defaults for each parameter
• Project could document its two instance attributes.

Otherwise good.

[Jonathan Lange]

It's worth taking another look at this. You too, radix.

[Jean-Paul Calderone]

Looks good to me.

[radix]

I watched commits in my inbox and agree with them. Given that exarkun properly reviewed this, I think it's ready for merging.

[Jonathan Lange]

(In [21908]) Unit-tested, understandable API for updating the version of Twisted.

• Authors: jml, radix
• Reviewers: exarkun, radix
• Fixes #2885

This is part of the new suite of automated release tools. It provides APIs for updating the version of Twisted and Twisted sub-projects using a new date-based version system.

Note that it removes the old admin/change-versions script without providing a replacement.

[Jean-Paul Calderone]

Reverted in [21909]

[Jonathan Lange]

(In [21911]) Unit-tested, understandable API for updating the version of Twisted.

• Authors: jml, radix
• Reviewers: exarkun, radix
• Fixes #2885

This is part of the new suite of automated release tools. It provides APIs for updating the version of Twisted and Twisted sub-projects using a new date-based version system.

Note that it removes the old admin/change-versions script without providing a replacement.

This re-merge fixes Python 2.3 support.