Opened 11 years ago
Closed 11 years ago
#2885 enhancement closed fixed (fixed)
Automate version updating (goodly)
Reported by: | radix | Owned by: | |
---|---|---|---|
Priority: | highest | Milestone: | twisted-8.0 |
Component: | release management | Keywords: | |
Cc: | Branch: |
branches/change-versions-2885-2
branch-diff, diff-cov, branch-cov, buildbot |
|
Author: | jml,radix |
Description
There should be some first-class code for updating version numbers in a Twisted branch.
Change History (18)
comment:1 Changed 11 years ago by
Branch: | → branches/change-versions-2885 |
---|
comment:2 Changed 11 years ago by
Branch: | branches/change-versions-2885 → branches/change-versions-2885-2 |
---|
(In [21731]) Branching to 'change-versions-2885-2'
comment:3 Changed 11 years ago by
Keywords: | review added |
---|---|
Owner: | radix deleted |
Priority: | normal → highest |
comment:4 Changed 11 years ago by
Milestone: | → twisted-7.0 |
---|
comment:5 Changed 11 years ago by
Keywords: | review removed |
---|---|
Owner: | set to Jonathan Lange |
- twisted/python/test/test_dist.py
- no copyright or module docstring
GetVersionTest
has no class docstring
- twisted/python/_release.py
- only the tests use
getCurrentVersion
- delete it?
- only the tests use
Ran out of time on this one, didn't get to look at most of the changes.
comment:6 Changed 11 years ago by
Keywords: | review added |
---|---|
Owner: | changed from Jonathan Lange to Jean-Paul Calderone |
Updated.
comment:7 Changed 11 years ago by
Status: | new → assigned |
---|
comment:8 Changed 11 years ago by
Keywords: | review removed |
---|---|
Owner: | changed from Jean-Paul Calderone to Jonathan Lange |
Status: | assigned → new |
It'd be good if all the test methods had docstrings, even the ones which just got moved and not modified (at least in test_release, although it'd be nice to spruce up test_dist as well), since supposedly a goal here is "first class release code".
test_findTwistedStyleProjects and test_getProjectName and test_updateTwistedVersionInformation use twisted and twisted.conch even though they're not operating on the real Twisted source. It might be clearer to use made up names here. test_updateTwistedVersionInformation also doesn't cover the case where baseDirectory
is None
. There aren't any users of this API either so I can't tell if that is the normal case or not. Maybe those arguments just shouldn't be optional?
replaceProjectVersion
writes out a string which refers to admin/change-versions
, which no longer exists.
comment:9 Changed 11 years ago by
Keywords: | review added |
---|---|
Owner: | changed from Jonathan Lange to Jean-Paul Calderone |
- Docstrings added for all
test_release
tests. Not so concerned abouttest_dist
, since they will likely be heavily modified by the tarball work. replaceProjectVersion
string changed to no longer refer toadmin/change-versions
.- Fixed
test_findTwistedStyleProjects
,test_getProjectName
andtest_updateTwistedVersionInformation
.
comment:10 Changed 11 years ago by
author: | → jml,radix |
---|
comment:11 Changed 11 years ago by
Keywords: | review removed |
---|---|
Owner: | changed from Jean-Paul Calderone to Jonathan Lange |
- twisted.python.test.test_release.ProjectTest.test_updateTwistedVersionInformation failing
- do something about the XXX in
twisted.python._release.getNextVersion
- updateTwistedVersionInformation still has a couple uncovered lines - the ones that handle the defaults for each parameter
Project
could document its two instance attributes.
Otherwise good.
comment:12 Changed 11 years ago by
Keywords: | review added |
---|---|
Owner: | changed from Jonathan Lange to Jean-Paul Calderone |
It's worth taking another look at this. You too, radix.
comment:13 Changed 11 years ago by
Owner: | changed from Jean-Paul Calderone to radix |
---|
Looks good to me.
comment:14 Changed 11 years ago by
Keywords: | review removed |
---|---|
Owner: | changed from radix to Jonathan Lange |
I watched commits in my inbox and agree with them. Given that exarkun properly reviewed this, I think it's ready for merging.
comment:15 Changed 11 years ago by
Resolution: | → fixed |
---|---|
Status: | new → closed |
(In [21908]) Unit-tested, understandable API for updating the version of Twisted.
- Authors: jml, radix
- Reviewers: exarkun, radix
- Fixes #2885
This is part of the new suite of automated release tools. It provides APIs for updating the version of Twisted and Twisted sub-projects using a new date-based version system.
Note that it removes the old admin/change-versions script without providing a replacement.
comment:17 Changed 11 years ago by
Resolution: | → fixed |
---|---|
Status: | reopened → closed |
(In [21911]) Unit-tested, understandable API for updating the version of Twisted.
- Authors: jml, radix
- Reviewers: exarkun, radix
- Fixes #2885
This is part of the new suite of automated release tools. It provides APIs for updating the version of Twisted and Twisted sub-projects using a new date-based version system.
Note that it removes the old admin/change-versions script without providing a replacement.
This re-merge fixes Python 2.3 support.
comment:18 Changed 8 years ago by
Owner: | Jonathan Lange deleted |
---|
(In [21717]) Branching to 'change-versions-2885'