Opened 15 years ago
Closed 14 years ago
#2874 enhancement closed fixed (fixed)
_sslverify.problemsFromTransport should be deprecated
Reported by: | therve | Owned by: | |
---|---|---|---|
Priority: | normal | Milestone: | |
Component: | core | Keywords: | |
Cc: | Branch: |
branches/delete-problemsFromTransport-2874
branch-diff, diff-cov, branch-cov, buildbot |
|
Author: | exarkun |
Description
It's obsolete, but we should first remove its use in amp.
Change History (7)
comment:1 Changed 14 years ago by
author: | → exarkun |
---|---|
Branch: | → branches/delete-problemsFromTransport-2874 |
comment:2 Changed 14 years ago by
comment:3 Changed 14 years ago by
Owner: | Glyph deleted |
---|
It's removed. There's one small change in behavior. AMP IBoxReceiver
s now get the underlying OpenSSL exception passed to their stopReceivingBoxes
method instead of an OpenSSLVerifyError
(which was never exposed publically).
The underlying OpenSSL exception has more useful information in it, so this seems like an improvement to me. The most likely way this could break someone's program is if they imported OpenSSLVerifyError
from the private twisted.internet._sslverify
and did type checking on exceptions. That exception is no longer defined, so they'll get an ImportError
.
Build results are here:
comment:4 Changed 14 years ago by
Keywords: | review added |
---|
comment:5 Changed 14 years ago by
Keywords: | review removed |
---|---|
Owner: | set to Jean-Paul Calderone |
Please merge.
comment:6 Changed 14 years ago by
Resolution: | → fixed |
---|---|
Status: | new → closed |
(In [24403]) Merge delete-problemsFromTransport-2874
Author: exarkun Reviewer: therve Fixes: #2874
Remove the private problemsFromTransport
API which exposed OpenSSL errors.
This API was redundant with IProtocol.connectionLost
, which is called
with a Failure
wrapped around an OpenSSL.SSL.Error
if there is a problem
with SSL which results in the connection being lost.
AMP is also changed to use the failure passed to connectionLost
rather
than problemsFromTransport
.
comment:7 Changed 11 years ago by
Owner: | Jean-Paul Calderone deleted |
---|
(In [24195]) Branching to 'delete-problemsFromTransport-2874'