Opened 10 years ago

Last modified 4 years ago

#2835 defect new

_pollingfile calls pauseProducing on registered Pull producers

Reported by: Peaker Owned by: John Popplewell
Priority: normal Milestone:
Component: core Keywords: windows
Cc: Branch:
Author:

Description

When a twisted.internet._pollingfile is used (a dumb win32 process) as a consumer, it tries to call pauseProducing on its producer, even if it registered as an IPullProducer.

The offending method is twisted.internet._pollingfile._PollableWritePipe.bufferFull

Attachments (2)

test_pollingfile-2835.patch (7.5 KB) - added by John Popplewell 4 years ago.
pull-producer-erroneous-pauseproducing.patch (5.0 KB) - added by John Popplewell 4 years ago.

Download all attachments as: .zip

Change History (8)

comment:1 Changed 7 years ago by Glyph

Owner: changed from Glyph to PenguinOfDoom

comment:2 Changed 6 years ago by <automation>

Owner: PenguinOfDoom deleted

comment:3 Changed 4 years ago by John Popplewell

Keywords: review added
Owner: set to John Popplewell
Priority: highestnormal
Status: newassigned

Attached is a patch to test_pollingfile.py which demonstrates the bug.

I have an abstract.FileDescriptor based fix to _pollingfile.py which resolves this and 5 other related bugs.

Changed 4 years ago by John Popplewell

Attachment: test_pollingfile-2835.patch added

comment:4 Changed 4 years ago by John Popplewell

Keywords: review removed

comment:5 Changed 4 years ago by John Popplewell

Keywords: windows review added
Owner: John Popplewell deleted
Status: assignednew

No longer calls pauseProducing() on a pull-producer. Includes test.

Changed 4 years ago by John Popplewell

comment:6 Changed 4 years ago by Tom Prince

Keywords: review removed
Owner: set to John Popplewell

See comments on #5365.

Note: See TracTickets for help on using tickets.