Opened 15 years ago

Closed 15 years ago

#2691 defect closed fixed (fixed)

internet.task.Clock.callLater does not fulfill IReactorTime.callLater contract

Reported by: washort Owned by:
Priority: highest Milestone:
Component: core Keywords:
Cc: Branch:
Author:

Description (last modified by washort)

IReactorTime.callLater is documented to return a DelayedCall that .cancel() can be called upon to cancel the delayed call. Clock.callLater returns the DelayedCall scheduled for the furthest in the future.

Change History (5)

comment:1 Changed 15 years ago by washort

Description: modified (diff)

comment:2 Changed 15 years ago by washort

Keywords: review added
Owner: changed from washort to Jean-Paul Calderone
Priority: normal → highest

Please review in calllater-identity-2691.

comment:3 Changed 15 years ago by Jean-Paul Calderone

Keywords: review removed
Owner: changed from Jean-Paul Calderone to washort

test_callLaterOrdering could use one more newline between it and testAdvance. Otherwise, looks great.

comment:4 Changed 15 years ago by washort

Resolution: → fixed
Status: new → closed

(In [20480]) Merge calllater-identity-2691.

Makes twisted.internet.task.Clock.callLater return the DelayedCall it creates, rather than the one scheduled furthest in the future.

Author: washort Reviewer: exarkun

Closes #2691.

comment:5 Changed 11 years ago by <automation>

Owner: washort deleted
Note: See TracTickets for help on using tickets.