Opened 15 years ago

Closed 12 years ago

#2689 defect closed fixed (fixed)

twisted.test.test_assertions is lonely

Reported by: Jean-Paul Calderone Owned by:
Priority: normal Milestone:
Component: trial Keywords:
Cc: jesstess, Thijs Triemstra Branch: branches/lonely-assertions-2689
branch-diff, diff-cov, branch-cov, buildbot
Author: jesstess

Description

This was added before the recent push to improve trial. Presumably it was passed over when trial's test suite was moved into twisted.trial.test. Hopefully everything it covers is covered elsewhere now, in which case it can just be deleted. Otherwise, it should be moved into the trial test suite.

Change History (10)

comment:1 Changed 13 years ago by jesstess

Author: jesstess
Branch: branches/lonely-assertions-2689

(In [27889]) Branching to 'lonely-assertions-2689'

comment:2 Changed 13 years ago by jesstess

Cc: jesstess added
Owner: changed from Jonathan Lange to jesstess

comment:3 Changed 13 years ago by jesstess

(In [27893]) Remove twisted/test/test_assertions.py as the functionality is duplicated in twisted/trial/test/test_assertions.py.

refs #2689

comment:4 Changed 13 years ago by jesstess

Keywords: review added
Owner: jesstess deleted

Changes in the branch:

  • Delete test_assertions.py. It had non-specifics tests for assertRaises and the errors ZeroDivisionError and ValueError, all of which are covered in the trial test_assertions.py
  • Make docstrings in the trial test_assertions.py conform to standard
  • Update copyright on the trial test_assertions.py

comment:5 Changed 12 years ago by Thijs Triemstra

Cc: Thijs Triemstra added
Keywords: review removed
Owner: set to jesstess

Copyright should be 2010 ;)

comment:6 Changed 12 years ago by jesstess

Keywords: review added
Owner: jesstess deleted

Copyright updated.

comment:7 Changed 12 years ago by TimAllen

Owner: set to TimAllen

comment:8 Changed 12 years ago by TimAllen

Keywords: review removed
Owner: changed from TimAllen to jesstess

Somewhat oddly, the deleted test tested assertRaises but the new tests don't — just lots of tests for failUnlessRaises. On the other hand, assertRaises is just an alias for failUnlessRaises, and the new tests actually use assertRaises quite a lot, so I guess it's actually getting tested anyway.

I say this branch is ready to merge!

comment:9 Changed 12 years ago by jesstess

Resolution: fixed
Status: newclosed

(In [27916]) Merge lonely-assertions-2689

Author: jesstess Reviewer: TimAllen Fixes: #2689

twisted/test/test_assertions.py can be deleted as the functionality it exercises is covered in trial/test/test_assertions.py.

comment:10 Changed 11 years ago by <automation>

Owner: jesstess deleted
Note: See TracTickets for help on using tickets.