Opened 15 years ago

Closed 15 years ago

#2630 defect closed fixed (fixed)

XMPP stream error conditions incorrectly qualified.

Reported by: njoyce Owned by:
Priority: highest Milestone: Words-0.6
Component: words Keywords:
Cc: njoyce, Ralph Meijer, therve Branch:
Author:

Description

http://www.xmpp.org/rfcs/rfc3920.html#rfc.section.4.7.2 states that the defined condition of the stream error must be qualified by urn:ietf:params:xml:ns:xmpp-streams, but t.w.p.j.error.getElement is using urn:ieft:params:xml:ns:xmpp-stanzas

Additionally, if the text arg is supplied it too is qualified incorrectly (should be urn:ietf:params:xml:ns:xmpp-streams).

Change History (7)

comment:1 Changed 15 years ago by Ralph Meijer

Cc: njoyce Ralph Meijer added
Milestone: Words-0.6
Owner: changed from Jean-Paul Calderone to Ralph Meijer
Priority: highnormal
Status: newassigned

comment:2 Changed 15 years ago by Ralph Meijer

Keywords: review added
Owner: Ralph Meijer deleted
Priority: normalhighest
Status: assignednew

Fixed in source:branches/xmpp-error-2630.

Please review.

comment:3 Changed 15 years ago by therve

Cc: therve added
Keywords: review removed
Owner: set to Ralph Meijer

The namespace attribute needs some documentation. I'm a bit worried about the break of the Error class (no more namespace), but I guess that's ok. Thanks!

comment:4 Changed 15 years ago by Ralph Meijer

Keywords: review added
Owner: changed from Ralph Meijer to therve

Added documentation and addressed the other comment by making it explicit that Error, now BaseError is a base class for StanzaError and StreamError.

Please review.

comment:5 Changed 15 years ago by therve

Keywords: review removed
Owner: changed from therve to Ralph Meijer

OK, go ahead and merge.

comment:6 Changed 15 years ago by Ralph Meijer

Resolution: fixed
Status: newclosed

(In [20498]) Use proper namespace for XMPP stream errors.

Author: ralphm Reviewer: therve Fixes #2630.

comment:7 Changed 11 years ago by <automation>

Owner: Ralph Meijer deleted
Note: See TracTickets for help on using tickets.