Opened 15 years ago

Closed 9 years ago

#2503 defect closed fixed (fixed)

Random garbage/debug prints in t-im irc support signon codepath

Reported by: Jean-Paul Calderone Owned by:
Priority: low Milestone:
Component: words Keywords:
Cc: jesstess, Thijs Triemstra Branch: branches/remove-test-import-2503
branch-diff, diff-cov, branch-cov, buildbot
Author: lvh

Description

connection made on irc service!? <twisted.words.im.ircsupport.IRCProto instance at 0xb733a98c>
uh, registering irc acct
signing onto testuser (IRC)

These should be removed.

Attachments (1)

ircsupport_chatter.patch (3.3 KB) - added by jesstess 13 years ago.
remove prints

Download all attachments as: .zip

Change History (11)

comment:1 Changed 15 years ago by Jean-Paul Calderone

Priority: normallow

Not bugging me so much this morning...

Changed 13 years ago by jesstess

Attachment: ircsupport_chatter.patch added

remove prints

comment:2 Changed 13 years ago by jesstess

Cc: jesstess added
Keywords: review added
Owner: Jean-Paul Calderone deleted

I only see this code getting used in twisted/words/im/instancemessenger.glade and zero test cases, so I'm not totally clear on what's going on with it (or what a glade file is...).

In any case it might as well not contribute to the open ticket count. The patch removes all print statements, not just those on the signon path, since they seemed equally chatty to me, but I can be more discriminating if need be.

comment:3 Changed 13 years ago by Thijs Triemstra

Cc: Thijs Triemstra added
Keywords: review removed
Owner: set to jesstess

I would not completely get rid of imgroup_testAction but pass it instead, like you did with the other methods:

def imgroup_testAction(self): 
    pass

Please apply patch after that.

comment:4 Changed 12 years ago by jesstess

Resolution: fixed
Status: newclosed

(In [27767]) Apply ircsupport_chatter.patch with minor tweaks

Author: jesstess Reviewer: thijs Fixes: #2503

Remove debugging print statements.

comment:5 Changed 11 years ago by <automation>

Owner: jesstess deleted

comment:6 Changed 9 years ago by lvh

Author: lvh
Branch: branches/remove-test-import-2503

(In [40585]) Branching to 'remove-test-import-2503'

comment:7 Changed 9 years ago by lvh

Please ignore that. Fat fingers, wrong ticket number :)

comment:8 Changed 9 years ago by lvh

(In [40589]) Merge remove-test-import-2053: remove test_import module

Author: ewong Reviewer: lvh Fixes: #2503

twisted.test.test_import was a vestigial module from back when Twisted had really bad test coverage. All it did was try to import (some of the) modules, and see if that raised any exceptions. It didn't really catch anything besides syntax errors or circular imports. Since all of the modules it imported have way better tests now, we can just go ahead and remove this.

comment:9 Changed 9 years ago by lvh

Resolution: fixed
Status: closedreopened

(In [40590]) Unmerge remove-test-import-2053

Reopens: #2503

This branch accidentally had the wrong topfile. This commit reopens #2503, which is actually an unrelated ticket, because the pre-commit hook is currently unable to grasp what went wrong.

comment:10 Changed 9 years ago by lvh

Resolution: fixed
Status: reopenedclosed

I had to reopen this because of the issue with #2053 (the two inner digits got switched), and the pre-commit hook was unable to deal with me wanting to reopen the *right* ticket, so I had to reopen this.

Since nothing actually happened on *THIS* ticket, I'm just closing it again.

Note: See TracTickets for help on using tickets.