Opened 15 years ago

Closed 15 years ago

#2394 defect closed invalid (invalid)

probable typo in twisted.internet._posixstdio

Reported by: soyt Owned by:
Priority: normal Milestone:
Component: core Keywords:
Cc: Branch:
Author:

Description

The world might collapse.

--- _posixstdio.py      2007-01-12 14:53:57.000000000 +0100
+++ _posixstdio.py.mine 2007-01-12 14:54:54.000000000 +0100
@@ -38,7 +38,7 @@
         self._reader=process.ProcessReader(reactor, self, 'read', stdin)
         self._reader.startReading()
         self._writer=process.ProcessWriter(reactor, self, 'write', stdout)
-        self._writer.startReading()
+        self._writer.startWriting()
         self.protocol.makeConnection(self)
 
     # ITransport

Change History (2)

comment:1 Changed 15 years ago by Jean-Paul Calderone

Resolution: invalid
Status: newclosed

I'm pretty sure the code is correct as written.

A FileDescriptor should not start writing until it has bytes in its output buffer. The ProcessWriter in question here certainly does have any of those by this point.

A FileDescriptor should start reading any time it cares about noticing a lost connection, though.

comment:2 Changed 11 years ago by <automation>

Owner: Glyph deleted
Note: See TracTickets for help on using tickets.