Opened 15 years ago

Closed 13 years ago

#2374 defect closed fixed (fixed)

testOpenSSLBuffering fails intermittently on a dapper machine (running in vmware) because it uses reactor.iterate

Reported by: radix Owned by:
Priority: normal Milestone:
Component: core Keywords:
Cc: Branch: branches/test-ssl-iterate-2374
branch-diff, diff-cov, branch-cov, buildbot
Author: therve


Test Pass 128
Running 1 tests.
    testOpenSSLBuffering ...                                             [FAIL]

[FAIL]: twisted.test.test_ssl.BufferingTestCase.testOpenSSLBuffering

Traceback (most recent call last):
  File "/home/radix/usr/lib/python2.4/site-packages/twisted/test/", line 369, in testOpenSSLBuffering
    self.assertEquals(client.buffer, ["+OK <some crap>\r\n"])
twisted.trial.unittest.FailTest: [] != ['+OK <some crap>\r\n']

The test uses reactor.iterate in a super lame way, and if I change the following line:

while i < 5000 and not client.buffer:

To have a larger upper bound (say, 50,000) it very reliably passes. It shouldn't be doing iterate explicitly.

Change History (7)

comment:1 Changed 13 years ago by therve

author: therve
Branch: branches/test-ssl-iterate-2374

(In [23461]) Branching to 'test-ssl-iterate-2374'

comment:2 Changed 13 years ago by therve

This should close #2918 too.

comment:3 Changed 13 years ago by therve

Owner: changed from jknight to therve

comment:4 Changed 13 years ago by therve

Keywords: review added; intermittent removed
Owner: therve deleted

comment:5 Changed 13 years ago by Jean-Paul Calderone

Keywords: review removed
Owner: set to therve

_runTest could use a docstring. Other than that, looks good. Merge when ready.

comment:6 Changed 13 years ago by therve

Resolution: fixed
Status: newclosed

(In [23717]) Merge test-ssl-iterate-2374

Author: therve Reviewer: exarkun Fixes #2374 Fixes #2918

Remove reactor.iterate calls from test_ssl.

comment:7 Changed 11 years ago by <automation>

Owner: therve deleted
Note: See TracTickets for help on using tickets.