Opened 19 years ago

Closed 12 years ago

#229 enhancement closed fixed (fixed)

t.im.basechat.ChatUI.contactChangedNick broken

Reported by: Jean-Paul Calderone Owned by:
Priority: low Milestone:
Component: words Keywords: im
Cc: Jean-Paul Calderone, acapnotic, fedora, jesstess Branch: branches/contact-changed-nick-229
branch-diff, diff-cov, branch-cov, buildbot
Author: jesstess

Description


Change History (14)

comment:1 Changed 19 years ago by Jean-Paul Calderone

It references a variable, "person" which does not exist.

comment:2 Changed 19 years ago by acapnotic

See my commit message for revision 1.8 (2/11/2003) -- that's
probably when I broke this.  What would you like to do about it?

comment:3 Changed 19 years ago by Moshe Zadka

im is deprecated and documented as not-really-working
Therefore, downgrading to feature.

comment:4 Changed 16 years ago by acapnotic

Component: words
Keywords: im added; words removed
Priority: normallow

google code search says nobody uses basechat.ChatUI. Can we delete it?

comment:5 Changed 16 years ago by Jean-Paul Calderone

The minchat example (one of the most run examples in Twisted, I think) uses it.

comment:6 Changed 12 years ago by jesstess

Cc: jesstess added

Is there any way for me to see what revision 1.8 changed?

comment:7 Changed 12 years ago by Jean-Paul Calderone

Looks like it corresponds to r5411

comment:8 Changed 12 years ago by jesstess

Author: jesstess
Branch: branches/contact-changed-nick-229

(In [28628]) Branching to 'contact-changed-nick-229'

comment:9 Changed 12 years ago by jesstess

Owner: changed from acapnotic to jesstess

comment:10 Changed 12 years ago by jesstess

(In [28632]) Use variables that actually exit and add unit tests for basechat.ChatUI.

refs #229

comment:11 Changed 12 years ago by jesstess

Keywords: review added
Owner: jesstess deleted

comment:12 Changed 12 years ago by Glyph

Keywords: review removed
Owner: set to jesstess

A few minor issues:

  1. There's some trailing whitespace in the tests.
  2. The test module should have a module docstring (it should be pretty trivial, just point at the basechat module)
  3. The tests refer to a 'person', they should probably have epytext links to IPerson.
  4. ChatUI's docstring isn't really accurate; it's not a GUI, it's sort of an event hub. Not really a problem for this branch, just thought I'd mention it. (I can't immediately think of a better thing though.)

Otherwise this really looks pretty good as is; address these issues to your satisfaction and then merge.

comment:13 Changed 12 years ago by jesstess

Resolution: fixed
Status: newclosed

Thanks for the review glyph. Your feedback was addressed in the branch, and then:

Merge contact-changed-nick-229

Author: jesstess Reviewer: glyph Fixes: #229

twisted.words.im.basechat.ChatUI now has a functional contactChangedNick with unit tests.

comment:14 Changed 11 years ago by <automation>

Owner: jesstess deleted
Note: See TracTickets for help on using tickets.