Opened 11 years ago

Closed 8 years ago

#2236 task closed wontfix (wontfix)

Make test_toc adhere to coding standard

Reported by: Jonathan Lange Owned by:
Priority: low Milestone:
Component: words Keywords:
Cc: Branch:
Author:

Description (last modified by Glyph)

  • fix vertical whitespace
  • add docstrings to tests
  • remove dead code (testCases variable, testSuite function)

Change History (6)

comment:1 Changed 11 years ago by Jonathan Lange

Summary: Make test_toc less skanky → Clean up test_toc

In particular:

  • test_toc has no regard for vertical whitespace
  • test should have docstrings explaining what the tests do
  • the tests in test_toc are extremely long and unclear. They should be split into actual unit tests.
  • in trunk, it defines an unused testCases variable

comment:2 Changed 11 years ago by Glyph

Description: modified (diff)
Summary: Clean up test_toc → Make test_toc adhere to coding standard

Let's restrict the scope of this ticket so it's achievable.

Also, why's it assigned to JP? This is z3p's code.

comment:3 Changed 11 years ago by Glyph

I just added #2238 to reflect the parts of this ticket which are beyond the scope of a simple cleanup.

comment:4 Changed 10 years ago by Jean-Paul Calderone

Owner: changed from Jean-Paul Calderone to z3p

comment:5 Changed 8 years ago by Thijs Triemstra

Resolution: → wontfix
Status: new → closed

Closing because TOC is going to be removed (#4363).

comment:6 Changed 7 years ago by <automation>

Owner: z3p deleted
Note: See TracTickets for help on using tickets.