Opened 13 years ago

Closed 10 years ago

#2113 enhancement closed wontfix (wontfix)

support uploads from Macromedia Flash 8 plugins

Reported by: yacc Owned by: yacc
Priority: normal Milestone:
Component: web2 Keywords:
Cc: jknight, yacc, Tv Branch:
Author:

Description

The attached patch provides workarounds for the broken http post file upload requests Flash generates.

Attachments (1)

twisted-patch (6.4 KB) - added by yacc 13 years ago.

Download all attachments as: .zip

Change History (7)

Changed 13 years ago by yacc

Attachment: twisted-patch added

comment:1 Changed 13 years ago by Jean-Paul Calderone

Cc: jknight yacc added
Keywords: review added

comment:2 Changed 13 years ago by jknight

Keywords: review removed
Owner: changed from jknight to yacc

Nice test cases. Is one, or both, byte-for-byte what flashplayer transmits? Under which circumstances? That should go in the test's comment.

The \n stripping is probably okay, but the special case for Submit Value is a bit gross.

If the testFlashUploadBrokenPartEnd test is correct, there isn't actually a problem, because, web2 passes that test just by removing the superfluous \n at the beginning. It's hard to tell what you thought that test was supposed to test cause it's comment says "FlashPlayer: superflous newline at the top" too.

the first -----------------------------155781040421463194511908194298--\r line signals the end of the MIME document, since it has the -- at the end. Everything after is just junk, and is simply ignored. It's still against spec to send it, but web2 already ignores the extra data.

comment:3 Changed 12 years ago by jknight

ping?

comment:4 Changed 12 years ago by sylvinus

Hi,

I confirm flash upload is broken.

Each uploads produces this error :

2007-06-09 17:22:14+0200 [-] Exception Unexpected data on same line as boundary: '--'

You can test what flash sends with this :

http://swfupload.mammon.se/index.php

(you can use firebug to alter the <form action= url and set a twisted.web2 post url)

Bug was reported here (second comment)

http://livedocs.adobe.com/flash/8/main/wwhelp/wwhimpl/common/html/wwhelp.htm?context=LiveDocs_Parts&file=00002225.html

I hope this helps to get the fix in the trunk!

comment:5 Changed 12 years ago by Tv

Cc: Tv added

comment:6 Changed 10 years ago by Thijs Triemstra

Resolution: wontfix
Status: newclosed
Summary: support uploads from Macromedia Flash pluginssupport uploads from Macromedia Flash 8 plugins

That doc link is broken but you can still grab the .zip from adobe. But that shouldn't be necessary since we're being fed Flash Player 10 nowadays and it's fixed by now.

Note: See TracTickets for help on using tickets.