Opened 16 years ago

Closed 16 years ago

#2089 defect closed fixed (fixed)

twisted.words.protocol.irc.IRC.whois references undefined variable RPL_WHOISOPER,

Reported by: Stephen Thorne Owned by: Cory Dodt
Priority: highest Milestone:
Component: words Keywords:
Cc: corydodt@… Branch:
Author:

Description

RPL_WHOISOPER should be RPL_WHOISOPERATOR I think.

Change History (6)

comment:1 Changed 16 years ago by Stephen Thorne

Component: corewords
Owner: changed from Glyph to Cory Dodt
Index: protocols/irc.py
===================================================================
--- protocols/irc.py    (revision 18110)
+++ protocols/irc.py    (working copy)
@@ -423,7 +423,7 @@
             self.hostname, RPL_WHOISSERVER, user, nick, server, serverInfo))
         if oper:
             self.sendLine(":%s %s %s %s :is an IRC operator" % (
-                self.hostname, RPL_WHOISOPER, user, nick))
+                self.hostname, RPL_WHOISOPERATOR, user, nick))
         self.sendLine(":%s %s %s %s %d %d :seconds idle, signon time" % (
             self.hostname, RPL_WHOISIDLE, user, nick, idle, signOn))
         self.sendLine(":%s %s %s %s :%s" % (

Test needed.

comment:2 Changed 16 years ago by Cory Dodt

Cc: corydodt@… added
Keywords: review added
Owner: Cory Dodt deleted

Created branch irc-whois-2089 and added a unit test for whois. This is ready for review now.

comment:3 Changed 16 years ago by Cory Dodt

Priority: normalhighest

comment:4 Changed 16 years ago by Jonathan Lange

Owner: set to Jonathan Lange
Status: newassigned

comment:5 Changed 16 years ago by Jonathan Lange

Keywords: review removed
Owner: changed from Jonathan Lange to Cory Dodt
Status: assignednew

Looks good to me. Please add a docstring to testWhois, then merge.

comment:6 Changed 16 years ago by Cory Dodt

Resolution: fixed
Status: newclosed

(In [18224]) Author: moonfallen, jerub Reviewer: jml Fixes #2089

Use the correct name for the constant and a test for whois.

Note: See TracTickets for help on using tickets.