Opened 15 years ago

Closed 15 years ago

Last modified 15 years ago

#2003 defect closed fixed (fixed)

pop3 tests don't cover both deprecated and undeprecated IMailbox behavior codepaths

Reported by: Jean-Paul Calderone Owned by:
Priority: highest Milestone:
Component: mail Keywords:
Cc: Branch:
Author:

Description

listMessages can raise a ValueError or an IndexError, but IndexError is about to be deprecated. The tests should cover both of these cases and suppress warnings from the deprecated one.

Change History (5)

comment:1 Changed 15 years ago by Jean-Paul Calderone

Keywords: review added
Owner: Jean-Paul Calderone deleted
Priority: normalhighest

Read for review in pop3-indexerror-tests-2003

comment:2 Changed 15 years ago by Stephen Thorne

Keywords: review removed
Owner: set to Jean-Paul Calderone

The level of effort you've gone to with the tests is amazing. Thankyou for your attention to detail. I don't especially like how you've copied the exact, long, string for the deprecation warning, but with deprecation warnings, it's for the best.

Please merge.

comment:3 Changed 15 years ago by Jean-Paul Calderone

Resolution: fixed
Status: newclosed

(In [17856]) Merge pop3-indexerror-tests-2003

Author: exarkun Reviewer: jerub Fixes #2003

This adds test coverage for the non-deprecated error handling codepaths in the POP3 server. It also adds suppressions for the pending deprecation warnings emitted from old codepaths.

comment:4 Changed 15 years ago by Jean-Paul Calderone

(In [17859]) Merge pop3-indexerror-tests-2003

Author: exarkun Reviewer: jerub Fixes #2003

This adds test coverage for the non-deprecated error handling codepaths in the POP3 server. It also adds suppressions for the pending deprecation warnings emitted from old codepaths.

comment:5 Changed 11 years ago by <automation>

Owner: Jean-Paul Calderone deleted
Note: See TracTickets for help on using tickets.