Opened 16 years ago

Closed 16 years ago

#1999 task closed fixed (fixed)

Move newpb out of trunk into a branch or separate package

Reported by: Jean-Paul Calderone Owned by:
Priority: highest Milestone:
Component: pb Keywords:
Cc: radix, warner, TimothyFitz Branch:


Based on the current failing state of the tests and the insufficient maintenance resources, new pb should be developed outside of Twisted trunk.

Putting this back into a branch is perfectly acceptable, but it may be useful to split it out into a separate (not sub-) project where releases can be made more easily and frequently to help get it some momentum.

Change History (11)

comment:1 Changed 16 years ago by warner

Status: newassigned

I agree. I intend to move it to a separate sub-project, with a new package name (not underneath twisted.*), at something like svn:// . That would help development and installation too, since it wouldn't have to be installed under twisted/ to be usable.

I'm trying to come up with a reasonable interim name now.

comment:2 Changed 16 years ago by warner

Keywords: review added
Owner: changed from warner to Jean-Paul Calderone
Priority: highhighest
Status: assignednew

I've moved newpb out to Twisted/sandbox/warner/Foolscap . I've created Twisted/branches/newpb-rename-1999 to handle the newpb-ectomy. newpb is now gone from that branch, and it's ready for review to make sure I didn't miss any traces of it.

I'll be releasing Foolscap-0.0.2 shortly, once I've gone through and finished renaming the internals and updating the docs.

comment:3 Changed 16 years ago by radix

Keywords: review removed
Owner: changed from Jean-Paul Calderone to warner

Looks good, please merge.

comment:4 Changed 16 years ago by Jean-Paul Calderone

Resolution: fixed
Status: newclosed

(In [18300]) Merge newpb-rename-1999

Author: warner Reviewer: radix Fixes #1999

Take newpb out of Twisted proper. Future development will take place somewhere else in the repository.

comment:5 Changed 16 years ago by warner

Cc: radix warner added
Priority: highesthigh
Resolution: fixed
Status: closedreopened

thanks for doing the merge.. it looks like the (empty) twisted/pb directory is still left over. Shall I create a new branch to remove this directory and begin the review process again?

comment:6 Changed 16 years ago by Jean-Paul Calderone

Keywords: review added
Owner: warner deleted
Priority: highhighest
Status: reopenednew

Reverted r18300, deleted twisted/pb/ from newpb-rename-1999. Can some people take a look over the branch and see if there's anything else left that needs to be removed?

comment:7 Changed 16 years ago by TimothyFitz

Owner: set to TimothyFitz

comment:8 Changed 16 years ago by TimothyFitz

Keywords: review removed
Owner: changed from TimothyFitz to warner

All tests pass on major platforms, and I can't find any reference to the newpb code. Things look good (passes review).

comment:9 Changed 16 years ago by TimothyFitz

Cc: TimothyFitz added

comment:10 Changed 16 years ago by warner

Resolution: fixed
Status: newclosed

(In [18362]) Remove newpb (twisted/pb) from trunk.

Author: warner

Reviewer: TimothyFitz

Fixes #1999

It has been moved into warner's sandbox, and renamed Foolscap for now. See for details.

comment:11 Changed 11 years ago by <automation>

Owner: warner deleted
Note: See TracTickets for help on using tickets.