Opened 15 years ago

Closed 15 years ago

#1988 defect closed fixed (fixed)

Cannot use a DeferredList to retrieve several POP3 messages

Reported by: kendrew Owned by:
Priority: highest Milestone:
Component: mail Keywords:
Cc: Jean-Paul Calderone, kendrew Branch:
Author:

Description


Change History (6)

comment:1 Changed 15 years ago by Jean-Paul Calderone

Cc: Jean-Paul Calderone kendrew added
Owner: changed from Jean-Paul Calderone to kendrew

I'm sorry, I don't know what this ticket means. You will need to provide more details. Ideally, you should attach a failing unit test to the ticket. At least attach a simple program I can run which you believe should work but which fails in some way. Please explain what the desired and actual behaviors are.

comment:2 Changed 15 years ago by Jean-Paul Calderone

Keywords: review added
Owner: kendrew deleted
Priority: normalhighest

I am guessing this ticket means:

p.retrieve(a) p.retrieve(b) p.retrieve(c)

doesn't work right, since it doesn't. Fix ready for review in pop3-concurrent-retrieve-1988

comment:3 Changed 15 years ago by radix

Owner: set to radix
Status: newassigned

comment:4 Changed 15 years ago by radix

Keywords: review removed
Owner: changed from radix to Jean-Paul Calderone
Status: assignednew

It looks like every function in _blockedQueue *needs* to reset self._blockedQueue to a list, given that there's code like

self._blockedQueue = None
f()
self._blockedQueue.extend(blah)

If my understanding is correct, I suggest changing the line "f()" to "f() # Must reset self._blockedQueue"

Otherwise +1.

comment:5 Changed 15 years ago by Jean-Paul Calderone

Resolution: fixed
Status: newclosed

(In [17820]) Merge pop3-concurrent-retrieve-1988

Author: exarkun Reviewer: radix Fixes #1988 Fixes #1691

This fixes the POP3 client to correctly unblock itself after a command completes successfully and there is more than one other command pending.

comment:6 Changed 11 years ago by <automation>

Owner: Jean-Paul Calderone deleted
Note: See TracTickets for help on using tickets.